[ .. ] xfpm-notify.c: In function ‘xfpm_notify_new_notification_internal’: xfpm-notify.c:212:5: error: too many arguments to function ‘notify_notification_new’ /usr/include/libnotify/notification.h:114:21: note: declared here make[3]: *** [xfce4_power_manager-xfpm-notify.o] Error 1 [ .. ] See how this should be fixed from Xfce Core packages where it works, or here: http://bugzilla.xfce.org/show_bug.cgi?id=7204 http://git.gnome.org/browse/network-manager-applet/commit/?id=68459b6b864ad45a842bfd1bdc80f126829ef596
Created attachment 3440 Fix for libnotify-0.7 The code could look like this, just needs the autotools bits added
Applied, thanks! Will go into 1.1.0
Sorry for attaching the incomplete patch here but I said "just needs the autotools bits added" so it wasn't complete :) Since you propably want a version that doesn't need configure.ac editing. Here: First add this after including notify.h to keep compability with old libnotify versions that didn't define NOTIFY_CHECK_VERSION yet: #ifndef NOTIFY_CHECK_VERSION #define NOTIFY_CHECK_VERSION(x,y,z) 0 #endif Then you can use: #if NOTIFY_CHECK_VERSION (0, 7, 0) do stuff that 0.7 supports #else do stuff that 0.4 and 0.5 supports #endif Examples here: http://git.xfce.org/apps/orage/commit/?id=bfa601ba135f84163eded2bb2e060e21d9ca08ce http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-i18n/uim/files/uim-1.6.1-libnotify-0.7.patch?revision=1.1&view=markup
Thanks, fixed, please reopen in case of problems.