7176 – Viewport scrolling in pager

Viewport scrolling in pager

Status:

RESOLVED: WONTFIX

Priority:
Medium

Severity:
enhancement

Product:
Xfce4-panel

Component:

Workspace Switcher

Comments

Description Nick Schermer editbugs

2011-01-24 08:37:50 CET

The patch in bug #3361 implements scrolling for viewports in the pager. The invert option makes no sense, so that could be skipped.

Comment 1 Paweł Tarasiuk 2011-05-11 13:47:36 CEST

Created attachment 3665 
Makes the mouse wheel over the pager switch between viewports

The comment about relation with the patches for bug #3361 is interesting. Unluckily, I haven't noticed the related patches from #3361 before fixing it myself... but let me attach my own patch for viewport scrolling, maybe someone finds it useful ;-).

Comment 2 Paweł Tarasiuk 2011-05-11 13:53:58 CEST

Created attachment 3666 
Makes the mouse wheel over the pager switch between viewports (cleaner version)

Comment 3 Nick Schermer editbugs

2011-05-11 14:03:15 CEST

Thanks for looking into this a couple of comments on the patch without trying it.

- There is a macro in common/ to check the list length: LIST_HAS_ONE_ENTRY.
- Indentation does not follow the style used in xfce4-panel.
- += 1 could be ++ as well, minor thingy.
- Take a look at http://git.xfce.org/xfce/xfce4-panel/tree/plugins/tasklist/tasklist-widget.c#n2754

Comment 4 Michael Kogan 2011-11-06 17:48:03 CET

Anything new here? :)

Bug #7176

Reported by:
Nick Schermer

Reported on: 2011-01-24
Last modified on: 2020-05-22

People

Assignee:
Nick Schermer

CC List:
3 users

Version

Version:
Unspecified

Target Milestone:
Panel 4.10

Attachments

Makes the mouse wheel over the pager switch between viewports (3.75 KB, patch) 2011-05-11 13:47 CEST , Paweł Tarasiuk	no flags
Makes the mouse wheel over the pager switch between viewports (cleaner version) (3.52 KB, patch) 2011-05-11 13:53 CEST , Paweł Tarasiuk	no flags

Additional information