Put a launcher on the desktop, filename is launchme.desktop , launcher name is "Me" Right click on the launcher located on the desktop -> "Rename" Change the name from "Me" to "You" Result : the launcher is destroyed : it's renamed as filename "You". Expected result was changing the Name= value in desktop file Same problem when editing it with "Properties"
How did this work in 4.6? I suppose the expected behavior would be to rename the file to "You.desktop" and change the Name field to "You", not just change the Name field.
The same issues is present in Thunar btw.
Here's what I think we could do: Given the launcher name X and filename Y.desktop, check if X and Y are equal when renaming from X to Z. If they are, rename the file to Z.desktop and set the Name to Z as well. If they are not, only set the Name field. BTW, please leave the importance of new bugs at the default. It is for us to decide whether a bug is a blocker or critical or has high importance.
This is a regression introduced in 4.8. Renaming of desktop entries was handled in a special case by thunar-vfs before as can be seen here: http://git.xfce.org/xfce/thunar-vfs/tree/thunar-vfs/thunar-vfs-io-local.c#n945 We need to implement the same special casing in Thunar and xfdesktop to fix the regression.
Actually, renaming is done via Thunar, so I'm moving this to Thunar even though it also affects xfdesktop.
Fixed in master and the xfce-4.8 branch of Thunar: commit f6bbdf98bae707b71c529d86e5896302c5119476 Author: Jannis Pohlmann <jannis@xfce.org> Date: Sun Jan 30 15:01:10 2011 +0100 Only change the Name field when renaming desktop files (bug #7155). This fixes a regression introduced in 4.8. In thunar-vfs we did the same thing we do now: when a desktop entry is to be renamed we only replace the Name field instead of renaming the file itself. This also affects xfdesktop which uses Thunar's rename feature through D-Bus.