! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
renaming launcher destroys the launcher


Description Zenwalk 2011-01-22 12:17:40 CET
Put a launcher on the desktop, filename is launchme.desktop , launcher name is "Me"
Right click on the launcher located on the desktop -> "Rename"
Change the name from "Me" to "You"
Result : the launcher is destroyed : it's renamed as filename "You". Expected result was changing the Name= value in desktop file

Same problem when editing it with "Properties"
Comment 1 Jannis Pohlmann editbugs 2011-01-22 12:30:18 CET
How did this work in 4.6? I suppose the expected behavior would be to rename the file to "You.desktop" and change the Name field to "You", not just change the Name field.
Comment 2 Jannis Pohlmann editbugs 2011-01-22 12:31:56 CET
The same issues is present in Thunar btw.
Comment 3 Jannis Pohlmann editbugs 2011-01-22 12:59:04 CET
Here's what I think we could do:

Given the launcher name X and filename Y.desktop, check if X and Y are equal when renaming from X to Z. If they are, rename the file to Z.desktop and set the Name to Z as well. If they are not, only set the Name field.

BTW, please leave the importance of new bugs at the default. It is for us to decide whether a bug is a blocker or critical or has high importance.
Comment 4 Jannis Pohlmann editbugs 2011-01-22 20:52:20 CET
This is a regression introduced in 4.8. Renaming of desktop entries was handled in a special case by thunar-vfs before as can be seen here:


We need to implement the same special casing in Thunar and xfdesktop to fix the regression.
Comment 5 Jannis Pohlmann editbugs 2011-01-30 14:43:37 CET
Actually, renaming is done via Thunar, so I'm moving this to Thunar even though it also affects xfdesktop.
Comment 6 Jannis Pohlmann editbugs 2011-01-30 15:07:25 CET
Fixed in master and the xfce-4.8 branch of Thunar:

commit f6bbdf98bae707b71c529d86e5896302c5119476
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Jan 30 15:01:10 2011 +0100

    Only change the Name field when renaming desktop files (bug #7155).
    This fixes a regression introduced in 4.8. In thunar-vfs we did the same
    thing we do now: when a desktop entry is to be renamed we only replace
    the Name field instead of renaming the file itself.
    This also affects xfdesktop which uses Thunar's rename feature through

Bug #7155

Reported by:
Reported on: 2011-01-22
Last modified on: 2011-01-30


Jannis Pohlmann
CC List:
1 user



Additional information