! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
underlinking issues prevent build with strict underlinking protection
Status:
RESOLVED: FIXED
Product:
Xfce4-mailwatch-plugin
Component:
General

Comments

Description Adam Williamson 2011-01-14 18:34:20 CET
Created attachment 3350 
fixes underlink issues

Building the plugin on a platform like Fedora Rawhide (and probably Debian or
Mandriva) fails due to underlinking issues; panel-plugin does not explicitly link against libxfcegui or libgcrypt. The attached patch fixes this. Specifying -lgcrypt directly in Makefile.am is fairly inelegant, but gcrypt doesn't ship a pkg-config file so it's not trivial to test for it in configure.ac, and it seems to be a dependency of gnutls anyway, so if gnutls is there, gcrypt should also be there. But it would probably be best to make up a test for gcrypt for configure, set up a variable for the -lgcrypt flag there, and put the variable in Makefile.am, I guess. I'm just too lazy. =)
Comment 1 Christoph Mende 2011-05-31 13:06:46 CEST
Created attachment 3704 
improved patch to link against gcrypt

it doesn't ship a pkgconfig file, but it ships an m4 macro that can be used.
attached patch fixes this in a bit better way, although I'm sure this can still be improved.
this patch doesn't include the libxfcegui4 fix though.
Comment 2 Ján Sučan editbugs 2013-11-25 00:47:29 CET
These linking issues are fixed.

Bug #7096

Reported by:
Adam Williamson
Reported on: 2011-01-14
Last modified on: 2013-11-25

People

Assignee:
Florian Rivoal
CC List:
3 users

Version

Version:
1.1.0 or older

Attachments

fixes underlink issues (629 bytes, patch)
2011-01-14 18:34 CET , Adam Williamson
no flags
improved patch to link against gcrypt (1.17 KB, patch)
2011-05-31 13:06 CEST , Christoph Mende
no flags

Additional information