! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
The iconbox height is several pixels greater than that of xfce4-panel.
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description John Wright 2005-01-18 00:50:07 CET
Regardless of the panel size setting, xfce4-iconbox is always a few pixels
larger than the panel.

Reproducible: Always
Steps to Reproduce:
1. Start XFCE4.
2. Run xfce4-iconbox.

Actual Results:  
Iconbox size doesn't match panel size.

Expected Results:  
Iconbox size should match panel size.

The patch is a one-liner, which I will attach after submitting the bug.
Comment 1 John Wright 2005-01-18 01:00:39 CET
Created attachment 153 
Changes the value of lsBorderWidth from 4 to 2, fixing bug 708
Comment 2 Jasper Huijsmans editbugs 2005-01-18 10:20:44 CET
Ok, I'll have a look tonight. Sounds correct.
Comment 3 Jasper Huijsmans editbugs 2005-01-18 15:32:52 CET
Right, I did somethng slightly different, but with the same effect. Below is the
patch I used. Thanks.


Index: ls_iconbox.c
===================================================================
RCS file: /var/cvs/xfce/xfce4/xfce4-iconbox/src/Attic/ls_iconbox.c,v
retrieving revision 1.6
diff -u -r1.6 ls_iconbox.c
--- ls_iconbox.c        7 Nov 2004 10:02:43 -0000       1.6
+++ ls_iconbox.c        18 Jan 2005 15:29:52 -0000
@@ -249,7 +249,7 @@
 void
 ls_iconbox_set_size (LSIconBox * plsib, glong lSize)
 {
-    int size = lsIconSize[lSize] + 2 * lsBorderWidth;
+    int size = lsIconSize[lSize] + lsBorderWidth;

     plsib->priv->lSize = lSize;
Comment 4 John Wright 2005-01-18 19:48:16 CET
Awesome.  Glad to have helped.
Comment 5 Nick Schermer editbugs 2011-01-24 08:43:20 CET
Move bug to Window Buttons; the merge of tasklist and iconbox.

Bug #708

Reported by:
John Wright
Reported on: 2005-01-18
Last modified on: 2011-01-24

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information