! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Startxfce4 overrides existing xdg data directories
Status:
RESOLVED: FIXED
Product:
Xfce-utils
Component:
General

Comments

Description Lionel Le Folgoc 2010-12-28 10:50:23 CET
Hi,

/usr/bin/startxfce4 seems to override existing xdg data directories by prepending @_datadir_@ to it (see line 37 of scripts/startxfce4.in).

According to the xdg spec (<http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html>), the first directory in the list is the most important one, so @_datadir_@ became the most important one, and any existing one, set, e.g., by the distributor is "overridden".

Thus, I guess that:
  XDG_DATA_DIRS="@_datadir_@:$XDG_DATA_DIRS"
should be replaced by
  XDG_DATA_DIRS="$XDG_DATA_DIRS:@_datadir_@"

Thanks!
Comment 1 Nick Schermer editbugs 2010-12-28 10:57:38 CET
Fixed in 40161f7.
Comment 2 Yves-Alexis Perez editbugs 2010-12-29 15:50:29 CET
Some care should be taken if XDG_DATA_DIR is empty, because that would give:

XDG_DATA_DIR=:@_datadir_@ and the empty string might not be a good thing to have there (remember the LD_LIBRARY_PATH security issues)
Comment 3 Nick Schermer editbugs 2010-12-29 18:51:12 CET
That should be covered by: if test "x$XDG_DATA_DIRS" = "x" right?

Bug #7040

Reported by:
Lionel Le Folgoc
Reported on: 2010-12-28
Last modified on: 2010-12-29

People

Assignee:
Xfce Bug Triage
CC List:
2 users

Version

Attachments

Additional information