! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
incorrect plugin name - extra unwanted charset conversion
Status:
RESOLVED: FIXED
Product:
Translations
Component:
General

Comments

Description Egmont Koblinger 2005-01-18 00:24:14 CET
Using the hu_HU locale, when I try to add a plugin to the panel, the
"Xfce menu" (which is "Xfce menu" with two dots on the "u" letter in Hungarian)
is displayed as "Xfce men", the last accented letter is missing. If I add this
to the panel, the balloon help behaves this way, too.

The hu.po file is correct. With hu_HU.UTF-8 locale Xfce behaves correctly,
the u with diaeresis is displayed. Hence I guess the bug is that someone
somewhere accidentally converts this string from UTF-8 to the current locale
and later passes it to pango which drops the invalid UTF-8 sequence.
Comment 1 Brian J. Tarricone (not reading bugmail) 2005-01-18 00:47:21 CET
no, there's no conversion going on anywhere.  JF, any ideas?
Comment 2 Jasper Huijsmans editbugs 2005-04-08 11:15:39 CEST
Could this be a gettext bug? I really don't see how this can happen.
Comment 3 Brian J. Tarricone (not reading bugmail) 2005-04-18 03:06:47 CEST
Jasper, JF, a question about i18n...  So for all shared-object plugins, the
plugin caption is set in the xfce_control_class_init() function, like so:

G_MODULE_EXPORT void
xfce_control_class_init(ControlClass *cc)
{
    /* ... */
    cc->caption = _("Xfce Menu");
    /* ... */
}

Now, how does this actually work?  At this point, xfce_textdomain() hasn't yet
been called (IIRC, that's done in the plugin's create_options() function). 
Granted, I don't really know all the ins and outs of gettext, so I might be
missing something here.

On a side note, looking in xfdesktop/trunk/po/hu.po:

#: panel-plugin/desktop-menu-plugin.c:205
#: panel-plugin/desktop-menu-plugin.c:535
msgid "Xfce Menu"
msgstr ""

Looks like it's not translated at all.  Though it is indeed translated in
xfce_4_2.  It looks like the value in the .po file is correct; "latin small
letter u with diaeresis" is listed as having the UTF-8 encoding of 0xC3 0xBC,
which is how it is in the .po file.

Ok, let's install the menu plugin from xfce_4_2 and try this out.  Right.  In
the "Add item" dialog of the panel, it just reads "Xfce Menu" (untranslated). 
However, if you add the item, the prefs panel pops up, and the default tooltip
title is "Xfce men

Bug #704

Reported by:
Egmont Koblinger
Reported on: 2005-01-18
Last modified on: 2009-07-14

People

Assignee:
Xfce Translations Team
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information