! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Error (with vala?) when compiling the notes plugin
Status:
RESOLVED: FIXED
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Cristian Marchi 2010-12-11 15:50:51 CET
That's the error I get when I run make:

make[2]: ingresso nella directory «/home/cristian/Xfce/xfce4-notes-plugin/lib»
  VALAC  libnotes_la_vala.stamp
icon-button.vala:117.3-117.33: error: Private member `Xnp.TitleBarButton.draw_icon' cannot be marked as override, virtual, or abstract
		private override void draw_icon (Cairo.Context cr, int width, int height) {
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)

I use vala from git and that's what I get when i run autogen.sh --prefix=/usr/local/ :

Build Configuration:

* Maintainer Mode:        yes

    * Vala:               /usr/local/bin/valac 0.11.2.25-30b2

* GTK+:                   2.20.1
* Xfce Panel:             4.7.6git-0879ad6
* Debug Support:          minimum

Now type "make" to compile.
Comment 1 Mike Massonnet editbugs 2010-12-19 12:00:29 CET
Try with the following patch (replace private against protected).

diff --git a/lib/icon-button.vala b/lib/icon-button.vala
index dbf495d..7816ce1 100644
--- a/lib/icon-button.vala
+++ b/lib/icon-button.vala
@@ -114,7 +114,7 @@ namespace Xnp {
 			Object (icon_type: icon_type);
 		}
 
-		private override void draw_icon (Cairo.Context cr, int width, int height) {
+		protected override void draw_icon (Cairo.Context cr, int width, int height) {
 			switch (icon_type) {
 				case TitleBarButtonType.CLOSE:
 					draw_close_button (cr, width, height);
Comment 2 Mike Massonnet editbugs 2010-12-19 20:34:55 CET
git 0e6f2830

Bug #6967

Reported by:
Cristian Marchi
Reported on: 2010-12-11
Last modified on: 2010-12-19

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information