Hi, Xfce4-power-information seems to call dbus_error_init(), but it doesn't link against libdbus directly, only libdbus-glib. It will make the linking fail with binutils-gold and/or --no-add-needed. The fix is probably to add $(DBUS_LIBS) to xfce4_power_information_LDADD in src/Makefile.am. Thanks!
Created attachment 3261 proposed patch My previous comment was probably wrong. libxfpmcommon.la and libxfpmdbus.la aren't linked against any lib. This seems wrong, and the build will fail later when linking some binaries (the brightness plugin and xfce4-power-information) against these la files. The attached patch fixes this issue for me (I put a random value in x11_minimal_version, feel free to change it). Also, the xfce4_brightness_plugin_LDADD change introduced by 4ceb85e5d9a1c8f18a094f462eb94c703ad1581d is useless with this patch, now that libxfpmcommon.la is correctly linked with its dependencies.
Mmmh, I used XDT_CHECK_PACKAGE([X11],…) and @X11_LIBS@, but this is probably wrong, XDT_CHECK_LIBX11() and @LIBX11_LIBS@ should be used instead.
Xfce4-power-information does not use dbus_error_init(), xfpm users dbus-glib only, i don't take the risk to base my code on dbus directly. I'll close this for now, please re-open if you have any problem.
% grep -Ri dbus_error_init * libdbus/xfpm-dbus.c: dbus_error_init (&error); libdbus/xfpm-dbus.c: dbus_error_init(&error); libdbus/xfpm-dbus.c: dbus_error_init(&error); Sorry, obviously you use libdbus directly, and you don't link directly to it (same for libx11).
And also please look at my second comment, where I wrote about the libs, not xfce4-power-information (which was wrong).
Created attachment 3324 fix linking against x11, dbus and randr Here's an updated version of the patch for 1.0.3
Thanks for the patch, applied and committed.