Description Christoph Wickert 2010-12-04 23:08:14 CET

There have been a couple of changes in libnotify 0.7.0:
notify_notification_new_with_status_icon   is gone
notify_notification_attach_to_status_icon  is gone
notify_notification_attach_to_widget       is gone
notify_notification_set_geometry_hints     is gone
notify_notification_new                    has lost its widget argument

The last one breaks thunar-volman:
tvm-notify.c: In function 'tvm_notify':
tvm-notify.c:42:3: error: too many arguments to function 'notify_notification_new'
/usr/include/libnotify/notification.h:79:21: note: declared here
make[2]: *** [thunar_volman-tvm-notify.o] Error 1

I was able to work around the problem with this simple fix:
$ diff -u thunar-volman-0.5.2.orig/thunar-volman/tvm-notify.c thunar-volman-0.5.2/thunar-volman/tvm-notify.c 
--- thunar-volman-0.5.2.orig/thunar-volman/tvm-notify.c	2010-07-25 23:08:49.000000000 +0200
+++ thunar-volman-0.5.2/thunar-volman/tvm-notify.c	2010-12-04 22:07:32.483164260 +0100
@@ -39,7 +39,7 @@
 {
   NotifyNotification *notification;
 
-  notification = notify_notification_new (summary, message, icon, NULL);
+  notification = notify_notification_new (summary, message, icon);
   notify_notification_set_urgency (notification, NOTIFY_URGENCY_NORMAL);
   notify_notification_set_timeout (notification, NOTIFY_EXPIRES_DEFAULT);
   notify_notification_show (notification, NULL);

Of course there needs to be a proper detection of the libnotify version, but
I'm too lazy for this right now.