I would like to ask you to add more hosts like imgur, yfrog, twitpic and others, as well to make login option for posting there (some of them can post without)
I made a patch to support anonymous imgur upload using libcurl and json-glib-1.0 (I couldn't download xfce4-screenshooter repository, http://git.xfce.org/git/apps/xfce4-screenshooter seems to be broken) https://github.com/seppo0010/xfce4-screenshooter/commit/f475df26782c21bcbc10170ebf75f23759fb3285 Probably authenticated users should be supported to publish, but it's a start.
I was posting a new file about ZimageZ image hosting when I see this one. I agree with Misha K., but for me, proving only one single anonymous image hosting (like imgur) istead of ZimageZ will be ok. That's why: 1) ZimageZ requires user registration. That means, every time I take a screenshot I want to share (and I want to do it quickly, for example for linking it in a IM app) I ask myself "should I use lot of my time NOW to make a new registration on ZimageZ, or it's better if I use a littel time I save and upload on imgur?". In the end, I never register and I always loose a little time for manual upload, when an automatic one will be zero-time consuming. 2) ZimageZ requires password. That means, an additional step, additional memory usage (in the sense, human memory, lol), additional time. 3) ZimageZ doesn't give you direct URL to image, but only formatted HTML tags. That it's useless, for example, when sharing via IM. Not only, if you visit your page, right click the image, and get a direct image URL, that URL is valid only for a short period of time. That means, I cannot use that direct URL for nothing, and I'm forced to visit the full brandized image-scale ZimageZ custom page. In conclusion: using something like imgur avoid ALL of these problema.
Just a "me too" here. ZimageZ seems very buggy and unprofessional to me. Imgur support would be excellent! http://api.imgur.com/
I do agree that ZimageZ is not the best option and that using imgur anonymously should be the default here. @Sebastian, attach here the patch (IMHO you can just throw away ZimageZ support and support only imgur) and you're done, Jérôme Guelfucci will do the rest of the work.
+1 with this. Is that patch still supported?
The patch was a bit unfinished (lacking Makefile.am/configure.ac.in goo), and wasnt checking for libsexy dependency either... i've cherrypicked the commits on top of current master, then fixed the autoconf/automake plumbing, but it would definitely need some improvements, and adding *three* new dependencies for that is a bit overkill. Anyway, builds and seems to work in basic testing here - see https://github.com/landryb/xfce4-screenshooter. I would have pushed it to a user repo on git.xfce.org but there are commits with broken author without email in the history.... (fe3a1d13dbc13a85aeae0e5b132cab404cd78e49 especially). Jerome, what do you think of it ?
Also, i've just realized it hardcodes an imgur api key (a094536e9503bf5e289b65a8116a8d1c), sebastian, where did you take that one ? Those days i'm pretty sure gtk2 has proper support for urls, so dropping the dependency on libsexy should be fairly easy. Patch/git clone is here for whoever wants to pickup the ball and polish the work :)
https://developer.gnome.org/gtk2/stable/gtk-migrating-label-links.html for migrating out of libsexy to plain gtk2, removing a dependency...
Removing libsexy dep wasnt hard, i've pushed some fixes commits to my github repo.
Hi Gaston :) here is the [patch] (http://sprunge.us/PKNR?diff) for [the master branch] (http://git.xfce.org/apps/xfce4-screenshooter) based on your commits.
(In reply to Ralf Teres from comment #10) > Hi Gaston :) > > here is the [patch] (http://sprunge.us/PKNR?diff) for [the master branch] > (http://git.xfce.org/apps/xfce4-screenshooter) based on your commits. I dont understand why you do this. the git repo i posted on github *is* a git repo on top of master branch. There's no need to extract a patch from it... it was only needed from sebastian's repo, which wasnt a proper git fork of the official repo. Also, other issues found while looking at it: - the api key has no known provenance. There's *no* way we're going to release anything without a proper api key - atm, it supports imgur api v2, while imgur only advertises v3 at http://api.imgur.com/ - which requires you to register the app with oauth2 first, and then ship it with the key generated at registration. So one would have to port the current code to the v3 of the api to make something "properly finished". Also, using a bugzilla account registered on bugmenot with bugmenot@mailinator.com is not really nice behaviour. I've disabled the account, open a proper account with a real mail address if you want to interact with developers......
> (In reply to Ralf Teres from comment #10) > > Hi Gaston :) > > > > here is the [patch] (http://sprunge.us/PKNR?diff) for [the master branch] > > (http://git.xfce.org/apps/xfce4-screenshooter) based on your commits. > > I dont understand why you do this. the git repo i posted on github *is* a > git repo on top of master branch. There's no need to extract a patch from > it... it was only needed from sebastian's repo, which wasnt a proper git > fork of the official repo. > Please calm down. Don't take me for more stupid than I am. What do you mean by "the git repo i posted on github *is* a git repo on top of master branch" because your repos it's just a fork of sebastian repo. But what I do, I have to *manually* merge your commits into a fork *of the _official_ xfce repo" then I have made diff patch. You welcome.... Good luck $plg$ĝ$$ù$ù
No, i think you misunderstood. If you look at the git history of https://github.com/landryb/xfce4-screenshooter/commits/master, it clearly shares the history of http://git.xfce.org/apps/xfce4-screenshooter/, while sebastian's repo doesnt (https://github.com/seppo0010/xfce4-screenshooter/commits/master). Do you understand how git works ? And please stop using anonymous accounts.
(In reply to Landry Breuil from comment #13) > No, i think you misunderstood. If you look at the git history of > https://github.com/landryb/xfce4-screenshooter/commits/master, it clearly > shares the history of http://git.xfce.org/apps/xfce4-screenshooter/, while > sebastian's repo doesnt > (https://github.com/seppo0010/xfce4-screenshooter/commits/master). > > Do you understand how git works ? And please stop using anonymous accounts. since the commit history does not really being chronological, especially because the last two commits before yours that are dated 2011, I believed wrongly understand that you had forked repo sebastian. I apologies for miscunderstood. Sorry And no, I will not use a dedicated account since is not necessary to report.
(In reply to Xfce User from comment #14) > (In reply to Landry Breuil from comment #13) > > No, i think you misunderstood. If you look at the git history of > > https://github.com/landryb/xfce4-screenshooter/commits/master, it clearly > > shares the history of http://git.xfce.org/apps/xfce4-screenshooter/, while > > sebastian's repo doesnt > > (https://github.com/seppo0010/xfce4-screenshooter/commits/master). > > > > Do you understand how git works ? And please stop using anonymous accounts. > > since the commit history does not really being chronological, especially > because the last two commits before yours that are dated 2011, I believed > wrongly understand that you had forked repo sebastian. The commits are dated 2011 because i git-cherrypicked them from his repo to ensure authorship/timestamps were properly kept.
Merged my wip work into master, switching to the v3 API and using a properly registered client-id. See http://git.xfce.org/apps/xfce4-screenshooter/commit/?id=57b85a84f760a235835e8a81a514fc587f2e625c (and the commits around this one) Will be in the next release.