! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop crash when cancel the copy of a file on desktop in some case


Description Skunnyk 2010-11-25 23:05:09 CET

Current xfdesktop (4.7.2) crash when desktop icons are enable and if I cancel the download of file.

How to reproduce:

Download a large file on desktop with your browser
File icon appear on the desktop during download
Cancel download
Xfdesktop crash

With --enable-debug=full :

DBG[xfdesktop-file-icon-manager.c:2143] xfdesktop_file_icon_manager_file_changed(): got changes done hint event: /home/skunnyk/Desktop/archlinux-2010.05-core-dual.iso.crdownload
ERROR:xfdesktop-file-icon-manager.c:2151:xfdesktop_file_icon_manager_file_changed: assertion failed: (file_info)
zsh: abort      xfdesktop
Comment 1 Jannis Pohlmann editbugs 2011-01-25 02:39:57 CET
Can you reproduce this with 4.8.0?
Comment 2 Skunnyk 2011-01-25 19:03:45 CET

Not the same behavior, xfdesktop always crash if I cancel the download, but it seems to respawn (  wallpaper become grey, and reappears, and the PID change).

I have this message in console:
ERROR:xfdesktop-file-icon-manager.c:2149:xfdesktop_file_icon_manager_file_changed: assertion failed: (file_info)

I'll try with debug later.
Comment 3 Skunnyk 2011-01-25 19:32:55 CET
Okay, with --enable-debug=full , I have the same output (but with respawn).

With gdb: 

DBG[xfdesktop-file-icon-manager.c:2141] xfdesktop_file_icon_manager_file_changed(): got changes done hint event: /home/skunnyk/Desktop/image.iso
ERROR:xfdesktop-file-icon-manager.c:2149:xfdesktop_file_icon_manager_file_changed: assertion failed: (file_info)

Program received signal SIGABRT, Aborted.
0xb7fe1424 in __kernel_vsyscall ()
(gdb) bt
#0  0xb7fe1424 in __kernel_vsyscall ()
#1  0xb74dec91 in raise () from /lib/libc.so.6
#2  0xb74e051e in abort () from /lib/libc.so.6
#3  0xb7666ccb in g_assertion_message () from /usr/lib/libglib-2.0.so.0
#4  0xb766722d in g_assertion_message_expr () from /usr/lib/libglib-2.0.so.0
#5  0x080758bd in ?? ()
#6  0xb794be26 in ?? () from /usr/lib/libgio-2.0.so.0
#7  0xb76dfa72 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#8  0xb76f28a0 in ?? () from /usr/lib/libgobject-2.0.so.0
#9  0xb76fb306 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#10 0xb76fb4b2 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#11 0xb78cf8fe in ?? () from /usr/lib/libgio-2.0.so.0
#12 0xb763ba81 in ?? () from /usr/lib/libglib-2.0.so.0
#13 0xb763fb72 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#14 0xb7640350 in ?? () from /usr/lib/libglib-2.0.so.0
#15 0xb7640a1b in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#16 0xb7b405b9 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#17 0x080570d6 in main ()

I can test with an other laptop tomorrow.
Comment 4 Jannis Pohlmann editbugs 2011-01-30 14:23:58 CET
Fixed in master and in the xfce-4.8 branch:

commit 171e0d79266b1ad6faedb7e7aee8dffb89b684e5
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sun Jan 30 14:19:08 2011 +0100

    Fix crash when cancelling a file download (bug #6876).
    Apparently, there are situations where a G_FILE_MONITOR_EVENT_CHANGED
    event is triggered for an existing file that has no GFileInfo any more.
    This commits removes an assertion that the GFileInfo is valid in those
    situations and instead, destroys the file icon when it's not.
    Also, this commit switches from G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT
    to G_FILE_MONITOR_EVENT_CHANGED although it shouldn't really matter
    which one we use.

Bug #6876

Reported by:
Reported on: 2010-11-25
Last modified on: 2011-01-30


Brian J. Tarricone (not reading bugmail)
CC List:
1 user



Additional information