! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use stock_copy instead of stock_folder-copy ( File operation dialog )
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description pyther 2010-11-17 22:05:37 CET
Created attachment 3193 
Changes icon used for file operation dialog window and systray applet

I would like to suggest using stock_copy instead of stock_folder-copy for a few reasons

1. Not many icon themes include stock_folder-copy
2. The default gnome theme does not include stock_folder_copy
3. gnome-icon-themes-extra does not contain stock_folder-copy
4. If stock_folder-copy does not exist in the icon them, you get the a "unknown" icon

An alternative solution would be to check to see if stock_folder-copy exists and if not, fall back on stock_copy.

I have attached a patch that changes stock_folder-copy to stock_copy.
Comment 1 Nick Schermer editbugs 2010-11-18 11:27:51 CET
I agree, lots of themes don't have this icon. That said, better use the GTK_STOCK_COPY macro.
Comment 2 Julien [nodiscc] editbugs 2011-01-11 15:19:38 CET
I agree, it should use stock_copy.
Comment 3 Jannis Pohlmann editbugs 2011-01-26 23:20:00 CET
This is fixed in master and I'm pondering to apply the same fix to xfce-4.8. I chose a different solution though which is to ship stock_folder-copy and stock_folder-move ourselves for the reason that there are no appropriate replacements in GTK+ or in the icon naming specification.

Feel free to comment if you disagree.

commit 8f7a02c162880e48891ea5528e3513d71ef6105f
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Wed Jan 26 23:17:18 2011 +0100

    Ship stock_folder-{copy,move}.png with Thunar itself (bug #6851).
    
    These icons were part of older gnome-icon-theme releases but have now
    disappeared. There are no useful equivalents in the icon naming
    specification or the GTK+ stock icons (well, there is GTK_STOCK_COPY,
    but no appropriate replacement for "stock_folder-move"), so for now it's
    best to ship the icons ourselves, I think.
Comment 4 pyther 2011-01-26 23:39:39 CET
Thanks. I think that solution would work alright. Do you know if the icons were intentionally removed from gnome-icon-theme?
Comment 5 Jannis Pohlmann editbugs 2011-01-26 23:54:00 CET
I don't know. They disappeared with this commit and never appeared again:

commit fd88a47bba6ee8c0419f9f97ce8c619e23babe89
Author: Jakub Steiner <jimmac@gmail.com>
Date:   Tue Oct 13 20:25:35 2009 +0200

    use moblin-style 'build system'

Bug #6851

Reported by:
pyther
Reported on: 2010-11-17
Last modified on: 2011-01-26

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Additional information