! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar-settings can't start in Thunar-1.1.3.
Status:
RESOLVED: FIXED

Comments

Description Tomoh K. 2010-11-04 02:11:26 CET
thunar-settings can't start in Thunar-1.1.3.

tomo@katura ~ $ thunar --version | head -1
Thunar 1.1.3 (Xfce 4.7.0)
tomo@katura ~ $ /usr/bin/thunar-settings 
Error org.freedesktop.DBus.Error.UnknownMethod: Method "DisplayPreferencesDialog" with signature "s" on interface "org.xfce.FileManager" doesn't exist

D-Bus method "org.xfce.FileManager.DisplayPreferencesDialog" needs two string argument.
(git commit id=43b57a28732cdfd4e7028ff23d79dc2d270ceef6)
But dbus-send command line in thunar-settings lacks second argument.
dbus-send --session --print-reply --dest=org.xfce.FileManager /org/xfce/FileManager \
    org.xfce.FileManager.DisplayPreferencesDialog "string:$DISPLAY" 1> /dev/null
So thunar-settings fails to start.
Comment 1 Robby Workman editbugs 2010-11-04 02:50:50 CET
Edit that script (at $bindir/thunar-settings) to look like this:

#!/bin/sh

test "x$DISPLAY" != "x" || DISPLAY=:0

dbus-send --session --print-reply --dest=org.xfce.FileManager /org/xfce/FileManager \
    org.xfce.FileManager.DisplayPreferencesDialog "string:$DISPLAY" \
    "string:$DESKTOP_STARTUP_ID"  1> /dev/null
Comment 2 Jannis Pohlmann editbugs 2010-11-04 08:48:29 CET
Thanks, I'll do a follow-up release later today with the fix included.
Comment 3 Nick Schermer editbugs 2010-11-04 13:48:44 CET
Don't think this is worth another release, but that up to you.
Comment 4 Jannis Pohlmann editbugs 2010-11-04 14:00:10 CET
Fixed in master:

commit c4b4fb48de2a106afb534ff2a2199ba57eac868c
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Thu Nov 4 13:58:12 2010 +0100

    Add startup parameter to the D-Bus call in thunar-settings (bug #6768).
    
    With the Thunar D-Bus API changes in the 1.1.3 release, thunar-settings
    did no longer start up. This fixes it.

Bug #6768

Reported by:
Tomoh K.
Reported on: 2010-11-04
Last modified on: 2010-11-04

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Additional information