! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
please port orage panel plugin to xfce4-panel 4.7
Status:
CLOSED: FIXED
Component:
clock-plugin

Comments

Description Yves-Alexis Perez editbugs 2010-10-17 11:35:39 CEST
Hey,

seems that orage won't build on Xfce 4.7:

libtool: link: gcc -DPACKAGE_DATA_DIR=\"/usr/share\" -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\" -pthread -I/usr/include/xfce4/libxfce4panel-1.0 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/xfce4 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -g -O2 -g -Wall -O2 -Wl,--export-dynamic -pthread -Wl,-z -Wl,defs -Wl,--as-needed -o xfce4-orageclock-plugin xfce4_orageclock_plugin-oc_config.o xfce4_orageclock_plugin-timezone_selection.o xfce4_orageclock_plugin-tz_zoneinfo_read.o xfce4_orageclock_plugin-xfce4-orageclock-plugin.o  -lxfce4panel-1.0 /usr/lib/libgtk-x11-2.0.so -lxfce4util /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libpangoft2-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangocairo-1.0.so /usr/lib/libcairo.so /usr/lib/libgio-2.0.so /usr/lib/libpango-1.0.so /usr/lib/libfreetype.so -lfontconfig /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so /usr/lib/libgthread-2.0.so -lrt /usr/lib/libglib-2.0.so -lX11 -pthread
xfce4_orageclock_plugin-oc_config.o: In function `oc_properties_options':
/tmp/buildd/orage-4.7.5/panel-plugin/oc_config.c:311: undefined reference to `xfce_create_framebox'
xfce4_orageclock_plugin-oc_config.o: In function `oc_properties_dialog':
/tmp/buildd/orage-4.7.5/panel-plugin/oc_config.c:471: undefined reference to `xfce_create_header'
xfce4_orageclock_plugin-oc_config.o: In function `oc_properties_appearance':
/tmp/buildd/orage-4.7.5/panel-plugin/oc_config.c:219: undefined reference to `xfce_create_framebox'
xfce4_orageclock_plugin-xfce4-orageclock-plugin.o: In function `popup_program':
/tmp/buildd/orage-4.7.5/panel-plugin/xfce4-orageclock-plugin.c:360: undefined reference to `xfce_exec'
collect2: ld returned 1 exit status
make[3]: *** [xfce4-orageclock-plugin] Error 1
make[3]: Leaving directory `/tmp/buildd/orage-4.7.5/panel-plugin'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/orage-4.7.5'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/tmp/buildd/orage-4.7.5'
make: *** [debian/stamp-makefile-build] Error 2

(it might need porting to libxfce4ui too)
Comment 1 juha editbugs 2010-10-18 08:38:31 CEST
Yes, I know... My problem has been that I have not been able to get 4.7 work. I am not sure which libraries are part of it. Need to try again.
Comment 2 Yves-Alexis Perez editbugs 2010-10-18 09:55:30 CEST
(In reply to comment #1)
> Yes, I know... My problem has been that I have not been able to get 4.7 work. I
> am not sure which libraries are part of it. Need to try again.

Build-depends for xfce4-panel are:

Build-Depends: debhelper (>= 7.0.50~), libxfce4util-dev (>= 4.6.0),
 libgarcon-1-0-dev (>= 0.1.1), libxfce4ui-1-dev (>= 4.7.1),
 libxfconf-0-dev (>= 4.7.2), libexo-1-dev (>= 0.5.1),
 libgtk2.0-dev (>= 2.14.0), libglib2.0-dev (>= 2.18.0),
 libdbus-glib-1-dev (>= 0.73), libcairo2-dev (>= 1.0.0),
 libwnck-dev (>= 2.22), libxml-parser-perl, intltool

Hope that helps
Comment 3 juha editbugs 2010-11-02 14:00:20 CET
Those symbols are actually all in the obsoleted libxfcegui4.
I managed to compile Orage and the panel plugin after adding it.
That should be fine as it works even though it is obsolete?
It is major effect to remove all those functions as none of them is available anymore, but needs to be coded using GTK+ only.
Comment 4 Nick Schermer editbugs 2010-11-03 09:40:55 CET
You need to link to libxfce4ui (which replaces gui4 to drop stuff that is either in gtk/libwnck).

The xfce_create_framebox replacement is xfce_gtk_frame_box_new or xfce_gtk_frame_box_new_with_content.

xfce_create_header has been removed (ie. not public api anymore), you should use XfceTitledDialog instead.

xfce_exec is now called xfce_spawn_*. Provides better support for spawning with startup notification etc.

The tarballs (http://archive.xfce.org/src/xfce/libxfce4ui/4.7/) contain api docs.
Comment 5 Nick Schermer editbugs 2010-11-03 09:41:41 CET
Btw, we will still release libxfcegui4 with all the api marked as deprecated, but it is wise (and not a lot of work) to use libxfce4ui.
Comment 6 juha editbugs 2010-11-03 12:13:22 CET
What is the replacement for xfce_about_info_new and where is this documented?
Comment 7 Nick Schermer editbugs 2010-11-03 12:17:30 CET
You should use GtkAboutDialog (slightly less functional, but it will do). There is no porting guide, I don't have time to write that since we're kinda busy getting core ready for 4.8; so feel free to ask ;-)
Comment 8 juha editbugs 2010-11-03 12:56:12 CET
ok. so basically the quick fix to THIS bug is to use the old library.
I will be porting Orage to the new ones, but that takes a while.
Comment 9 Nick Schermer editbugs 2010-11-03 13:47:05 CET
You only need to make sure the panel plugin links to libxfcegui4, because that is not a libxfce4panel dependency anymore.
Comment 10 juha editbugs 2011-01-18 14:17:50 CET
in 4.8.0

Bug #6737

Reported by:
Yves-Alexis Perez
Reported on: 2010-10-17
Last modified on: 2011-01-18

People

CC List:
1 user

Version

Attachments

Additional information