! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Tumbler does not rotate image thumbnails correctly
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Jérôme Guelfucci editbugs 2010-10-10 18:45:57 CEST
Thumbnails for jpg images do not respect the rotation informations.
Comment 1 Jannis Pohlmann editbugs 2010-10-10 18:58:49 CEST
Confirmed. I think the issue was present in thunar-vfs already and the cause has to be somewhere in the code I moved over from thunar-vfs to the JPEG thumbnailer plugin for tumbler.
Comment 2 Lionel Le Folgoc 2012-04-21 13:17:21 CEST
Created attachment 4351 
Proposed patch for the pixbuf thumbnailer

The code of both plugins (jpeg and pixbuf) ignores the "Exif.Image.Orientation" property, and so the thumbnail isn't correct.

For pixbuf, it's an easy fix, see attached patch. To test I played with exiv2, e.g.:
$ exiv2 -PEkyct photo.JPG | grep Orientation
$ exiv2 -M "set Exif.Image.Orientation Short 4" mo photo.JPG
(I used 4 to test, but whatever between 1 and 8 works)

For jpeg, it's different, because it can either use the exif thumbnail (nothing to do, we trust it to be correct, too bad if it is not), or the picture itself, and in that case it needs to do something like <http://git.gnome.org/browse/gdk-pixbuf/tree/gdk-pixbuf/io-jpeg.c#n314>.

Does it really make sense to keep two distinct thumbnailers for jpeg? (Ideally, jpeg would only use the EXIF thumbnail, and if not present pass the file to the pixbuf thumbnailer, which already DTRT I guess)
Comment 3 Nick Schermer editbugs 2012-12-08 18:21:55 CET
Fixed in 4e2cc92 for the jpeg thumbnailer and 59ec63 for the pixbuf thumbnailer.

Bug #6730

Reported by:
Jérôme Guelfucci
Reported on: 2010-10-10
Last modified on: 2012-12-08

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

Proposed patch for the pixbuf thumbnailer (888 bytes, patch)
2012-04-21 13:17 CEST , Lionel Le Folgoc
no flags

Additional information