! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-cpugraph-plugin uses "xfce-mouse" as app-icon
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-cpugraph-plugin
Component:
General

Comments

Description Simon Steinbeiss editbugs 2010-09-14 09:33:26 CEST
the respective .desktop file in /usr/share/xfce4/panel-plugins uses "xfce-mouse" in its "Icon=" line.
please replace that by something more meaningful (and theme-ingful ;) ) like "xfce4-cpugraph-plugin".

(same bug reported on launchpad: https://bugs.launchpad.net/ubuntu/+source/xfce4-cpugraph-plugin/+bug/636543 )
Comment 1 Lionel Le Folgoc 2010-09-15 18:52:54 CEST
Or maybe 'utilities-system-monitor', which already exists in icon themes, and is a bit more informative?
Comment 2 Florian Rivoal editbugs 2010-09-29 16:49:20 CEST
I am not against having a dedicated icon, but someone would need to draw one and give it to me, as I don't trust my graphics skills too much.

As for using utilities-system-monitor, I am not sure I want to reuse an icon that supposed to represent a different piece of software, even if they are indeed related, as I wouldn't want to weaken the user's mental association of what that icon usual refers to.

Or am I mistaken? Is this icon supposed to be used by all sorts of system-monitor-ish tools, rather than a specific one?
Comment 3 Simon Steinbeiss editbugs 2010-10-04 01:50:51 CEST
I think that it would be good if cpugraph had a specific icon, I would volunteer to make an icon based on the one used by the cpufreq-applet, which in turn seems to be coming from the tango set (http://lists.freedesktop.org/archives/tango-artists/2006-April/000413.html).
It seems that most xfce4-panel-plugins only have one icon, which is 48px. Would that be sufficient for you or would you like to have smaller icon sizes too?
Comment 4 Simon Steinbeiss editbugs 2010-10-04 02:03:14 CEST
Created attachment 3124 
proposed icon for xfce4-cpugraph-plugin

mashup of gnome's apps/utilities-system-monitor and tango's devices/cpu
Comment 5 Florian Rivoal editbugs 2010-10-04 03:40:27 CEST
Looks nice! Thanks a lot. I am glad I asked, rather than try to do it myself.

Having other sizes isn't quite as important as having an icon at all, but if it isn't too much work, I'd appreciate having a few sizes under 48, and if you made it that way, an svg version would be great too.
Comment 6 Simon Steinbeiss editbugs 2010-10-04 09:11:16 CEST
Created attachment 3125 
cpugraph icon 16px
Comment 7 Simon Steinbeiss editbugs 2010-10-04 09:11:36 CEST
Created attachment 3126 
cpugraph icon 22px
Comment 8 Simon Steinbeiss editbugs 2010-10-04 09:12:58 CEST
Unfortunately I couldn't find the svg sources of the icons - that would have also made my life easier. So all I can offer right now is png. Hope that's ok.

I quickly made a 16px and 22px variant of the icon.
Comment 9 Simon Steinbeiss editbugs 2010-10-04 09:23:03 CEST
I actually just enhanced the icons a bit visually (more contrast for the graph-part), I wanted to remove the currently attached icons from bugreport, but it seems even though it was me who added them I can't.
So I attach them as a tarball now containing 16,22 and 48.
Comment 10 Simon Steinbeiss editbugs 2010-10-04 09:23:35 CEST
Created attachment 3127 
enhanced cpugraph icons, 16, 22 and 48.
Comment 11 Florian Rivoal editbugs 2010-10-04 11:24:13 CEST
Too bad for the svg, but I'll do without. Thanks for the icons. I'll be integrating them soon.
Comment 12 Simon Steinbeiss editbugs 2010-10-04 11:44:14 CEST
(In reply to comment #11)
> Too bad for the svg, but I'll do without. Thanks for the icons. I'll be
> integrating them soon.

I agree, if I have time I'll try to redo them in svg. (Not sure how soon that'll be... :/ )
Thanks for integrating them!
Comment 13 Florian Rivoal editbugs 2010-10-04 13:46:14 CEST
I have integrated the icons, and used them not only for the .desktop file, but also in the Properties dialog.

The changes have been integrated to master, and will be used in the next version after the recently released 1.0.0

To make life easier to distros that would want to use these changes on top of 1.0.0, without waiting for the following release, they are also on a branch called "taskbranch/bug-6700" which starts from the "xfce-cpugraph-plugin-1.0.0" tag.
Comment 14 Florian Rivoal editbugs 2010-10-04 16:06:13 CEST
Also started using the icon as a logo on the wiki page:
http://goodies.xfce.org/projects/panel-plugins/xfce4-cpugraph-plugin

Bug #6700

Reported by:
Simon Steinbeiss
Reported on: 2010-09-14
Last modified on: 2010-10-04

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Version:
0.3.0 or older

Attachments

proposed icon for xfce4-cpugraph-plugin (3.41 KB, image/png)
2010-10-04 02:03 CEST , Simon Steinbeiss
no flags
cpugraph icon 16px (787 bytes, image/png)
2010-10-04 09:11 CEST , Simon Steinbeiss
no flags
cpugraph icon 22px (1.36 KB, image/png)
2010-10-04 09:11 CEST , Simon Steinbeiss
no flags
enhanced cpugraph icons, 16, 22 and 48. (5.74 KB, application/x-gzip)
2010-10-04 09:23 CEST , Simon Steinbeiss
no flags

Additional information