! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
clipman should use xfce4-clipman-trayicon instead of gtk-paste
Status:
CLOSED: FIXED
Severity:
trivial
Product:
Xfce4-clipman-plugin
Component:
General

Comments

Description Simon Steinbeiss editbugs 2010-09-12 17:18:39 CEST
i'm currently working on an icon-theme for xfce with monochrome tray- and panel-icons.
the clipman plugin unfortunately uses the generic paste-icon (gtk-paste or edit-paste, can't remember now) as its trayicon, it would be a lot nicer to be able to theme that specifically. currently it's impossible for me to theme the clipman-plugin because i have a dark panel background but a bright toolbar and menus.

maybe clipman could use its app-icon as a trayicon (like other apps do, e.g. xfce-dict or the notes-plugin) and the generic paste-icon only as fallback.
Comment 1 Mike Massonnet editbugs 2010-09-12 17:50:02 CEST
I once used the icon xfce4-clipman-plugin but I received later a bug report that it doesn't follow the theme icon. Indeed this icon name is not available in any external icon themes.

I don't have anything against using a themed icon, and I believe I can easily check if it exists before applying it in a way to fallback safely against the gtk stock icon.

However I need a better name than xfce4-clipman-trayicon. It should be even more generic and not contain xfce4. I'll have a look at Tango/Freedesktop to see what could be ideal, nonetheless any suggestion is welcome :)
Comment 2 Simon Steinbeiss editbugs 2010-09-12 18:11:02 CEST
> However I need a better name than xfce4-clipman-trayicon. It should be even
> more generic and not contain xfce4. I'll have a look at Tango/Freedesktop to
> see what could be ideal, nonetheless any suggestion is welcome :)

well that's great news. i agree that my initial suggestion is not ideal, actually using xfce4-clipman-plugin primarily and gtk-paste as fallback would work for me.
(since panels are usually not *huge* icon-theme-authors could distinguish between the panel and the app-icon by size. i already do that for quite a few xfce-panel-icons...)

alternatively you could simply use "clipman". looking at what other apps do in this case i have to say that many use suffixes for different icon-states (like the xfpm-icons), but since clipman only has one state it only needs one icon and therefore could have this very short, generic name.
Comment 3 Simon Steinbeiss editbugs 2010-10-29 12:05:04 CEST
Created attachment 3160 
bright and dark monochrome paste-icons to test in the panel
Comment 4 Mike Massonnet editbugs 2010-10-29 18:51:49 CEST
Lovely icons!

I wondered about the naming, I think a good name could be clipman-applet (a tad more accurate) but I could go for just "clipman".

I'll adapt the source code and let you know.

Kind Regards.
Comment 5 Mike Massonnet editbugs 2011-05-07 21:37:58 CEST
committed in git 758c09

Hi Simon,

the icon name is "clipman", if there is no such icon name in the icon theme, it falls back to "edit-paste".

Cheers
Mike
Comment 6 Simon Steinbeiss editbugs 2011-05-10 11:09:21 CEST
(In reply to comment #5)
> committed in git 758c09
> 
> Hi Simon,
> 
> the icon name is "clipman", if there is no such icon name in the icon theme, it
> falls back to "edit-paste".
> 
> Cheers
> Mike

thanks mike! will add the icon to xubuntu's icon theme right away.

Bug #6698

Reported by:
Simon Steinbeiss
Reported on: 2010-09-12
Last modified on: 2012-04-09

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

bright and dark monochrome paste-icons to test in the panel (1.39 KB, application/x-gzip)
2010-10-29 12:05 CEST , Simon Steinbeiss
no flags

Additional information