! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[reviewed patch] Use LT_{INIT,PREREQ} instead of AC_PROG_LIBTOOL to not build...
Status:
RESOLVED: FIXED
Product:
Xfce4-datetime-plugin
Component:
General

Comments

Description Samuli Suominen 2010-08-24 02:28:25 CEST
Created attachment 3086 
Build only shared plug-in

Plugins shouldn't have --enable-static enabled by default. Longer compile time, more HDD space, no use... pointless file.

Attached patch fixes the issue
Comment 1 Diego Ongaro 2010-09-01 05:53:37 CEST
(In reply to comment #0)
> Created an attachment (id=3086) [details]
> Build only shared plug-in
> 
> Plugins shouldn't have --enable-static enabled by default. Longer compile time,
> more HDD space, no use... pointless file.
> 
> Attached patch fixes the issue

It seems like your arguments apply equally to all plugins, not just datetime. Do any of them not build a static library?
Comment 2 Samuli Suominen 2010-09-01 10:36:14 CEST
(In reply to comment #1)
> (In reply to comment #0)
> > Created an attachment (id=3086) [details] [details]
> > Build only shared plug-in
> > 
> > Plugins shouldn't have --enable-static enabled by default. Longer compile time,
> > more HDD space, no use... pointless file.
> > 
> > Attached patch fixes the issue
> 
> It seems like your arguments apply equally to all plugins, not just datetime.
> Do any of them not build a static library?

Only plugins that build static archives are:

datetime, notes and sensors

And I assume all of them are by mistake (= missing libtool syntax for not doing so)

My patch uses syntax that has been available since libtool-2.2.6 (the new syntax), therefore the LT_PREREQ, but I'm sure you'll find alternative syntaxes from any other than datetime, notes or sensors if required...
Comment 3 Samuli Suominen 2011-11-04 18:11:38 CET
Now with bug 6920 closed, this patch can be applied as is.
Comment 4 Landry Breuil editbugs 2013-02-13 22:50:59 CET
Finally(!) fixed in 61eba53

Bug #6659

Reported by:
Samuli Suominen
Reported on: 2010-08-24
Last modified on: 2013-02-13

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Version:
unspecified

Attachments

Build only shared plug-in (505 bytes, patch)
2010-08-24 02:28 CEST , Samuli Suominen
no flags

Additional information