! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-panel-4.7.2: libxfce4panel-1.0.pc is missing variable localedir (requir...
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Libxfce4panel

Comments

Description Samuli Suominen 2010-08-10 21:47:39 CEST
xfce4-panel-4.6.4 has variable called "localedir" in it's pkg-config file, but 4.7.2 doesn't.

it's required by xfce4-xfapplet-plugin, please see:

http://foo-projects.org/pipermail/xfce4-dev/2007-May/023068.html
http://foo-projects.org/pipermail/xfce4-dev/2007-May/023069.html

./configure output of xfce4-xfapplet-plugin:

checking for libxfce4panel-1.0 >= 4.3.20... 4.7.2
[ .. ]
checking for libxfce4panel-1.0 localedir... not found
*** You need xfce4-panel 4.3 (SVN) >= r19874 to ***
*** compile xfce4-xfapplet-plugin.              ***

the offending code in configure.ac:

dnl check special variable localedir for libxfce4panel
AC_MSG_CHECKING([for libxfce4panel-1.0 localedir])
LIBXFCE4PANEL_LOCALE_DIR=`$PKG_CONFIG --variable=localedir libxfce4panel-1.0`
if test "none$LIBXFCE4PANEL_LOCALE_DIR" = "none"; then
   AC_MSG_RESULT([not found])
   echo '*** You need xfce4-panel 4.3 (SVN) >= r19874 to ***'
   echo '*** compile xfce4-xfapplet-plugin.              ***'
   exit 1
fi
AC_MSG_RESULT([$LIBXFCE4PANEL_LOCALE_DIR])
AC_SUBST([LIBXFCE4PANEL_LOCALE_DIR])

i'm not sure if this is a bug in xfce4-panel or xfce4-xfapplet-plugin, if the removal was intentional, or not...
Comment 1 Samuli Suominen 2010-08-10 21:56:04 CEST
panel-plugin.c in xfapplet is using following:

xfce_textdomain ("xfce4-panel", LIBXFCE4PANEL_LOCALE_DIR, "UTF-8");

so propably it needs to be readded to xfce4-panel
Comment 2 Samuli Suominen 2010-08-10 22:05:30 CEST
Created attachment 3072 
Restore localedir varible to pkg-config file
Comment 3 Nick Schermer editbugs 2010-08-11 11:23:26 CEST
Fixed in 7f344b8.

Bug #6629

Reported by:
Samuli Suominen
Reported on: 2010-08-10
Last modified on: 2010-08-11

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
4.7 (master)

Attachments

Additional information