6621 – xfce4-radio-plugin-0.4.2 fails to build with xfce4-panel-4.7 (missing libxfcegui4 linking)

xfce4-radio-plugin-0.4.2 fails to build with xfce4-panel-4.7 (missing libxfce...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-radio-plugin

Component:

General

Comments

Description Samuli Suominen 2010-08-08 15:52:51 CEST

Created attachment 3065 
Fix for building (linking)

because xfce4-panel-4.7 is using libxfce4ui instead of libxfcegui4, we need direct linking to libxfcegui4 in xfce4-radio-plugin:

xfce4_radio_plugin-xfce4-radio.o: In function `xfce4_radio_stop':
xfce4-radio.c:(.text+0xc72): undefined reference to `xfce_exec'
xfce4_radio_plugin-xfce4-radio.o: In function `mouse_click':
xfce4-radio.c:(.text+0x1823): undefined reference to `xfce_exec'
collect2: ld returned 1 exit status

full build.log here:

https://bugs.gentoo.org/attachment.cgi?id=241741

attached patch solves the issue

Comment 1 Stefan Ott 2010-08-09 02:41:52 CEST

Thanks for reporting (and for the patch), I'll have a look at it in the next couple of days.

cheers
Stefan

Comment 2 Stefan Ott 2010-08-12 03:41:16 CEST

Okay, I tried your patch and it seems to work just fine. Unfortunately I currently don't have access to the repo, thus I'll abuse this tracker and attach another patch which will be applied to the VCS ASAP.

Comment 3 Stefan Ott 2010-08-12 03:41:45 CEST

Created attachment 3077 
Patch against VCS

Comment 4 Stefan Ott 2010-10-26 03:18:30 CEST

Fixed in 0.4.3

Bug #6621

Reported by:
Samuli Suominen

Reported on: 2010-08-08
Last modified on: 2010-10-26

People

Assignee:
Stefan Ott

CC List:
0 users

Version

Version:
unspecified

Target Milestone:
---

Attachments

Fix for building (linking) (1.14 KB, application/octet-stream) 2010-08-08 15:52 CEST , Samuli Suominen	no flags
Patch against VCS (1.04 KB, patch) 2010-08-12 03:41 CEST , Stefan Ott	no flags

Additional information