! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-verve-plugin-0.3.6: Fix exo-0.5 detection AND link properly to libxfcegui4
Status:
RESOLVED: FIXED
Product:
Xfce4-verve-plugin
Component:
General

Comments

Description Samuli Suominen 2010-08-07 17:18:09 CEST
Created attachment 3060 
Detect both, new and old exo

First patch explains itself, adds exo-0.5 support to configure.ac. Doesn't seem to require more changes.

The second one is LDFLAGS vs. LDADD typing error in Makefile.am and missing libxfcegui4 LIBS and CFLAGS because xfce4-panel-4.7 is using libxfce4ui instead, so it won't get inherited from there anymore.

Full build.log:

https://bugs.gentoo.org/attachment.cgi?id=241739

The important part of the build.log:

fce4_verve_plugin-verve-plugin.o: In function `verve_plugin_keypress_cb':
verve-plugin.c:(.text+0x769): undefined reference to `xfce_err'
xfce4_verve_plugin-verve-plugin.o: In function `verve_plugin_properties':
verve-plugin.c:(.text+0xc80): undefined reference to `xfce_titled_dialog_new_with_buttons'
verve-plugin.c:(.text+0xd15): undefined reference to `xfce_create_framebox'
verve-plugin.c:(.text+0xed3): undefined reference to `xfce_create_framebox'
Comment 1 Samuli Suominen 2010-08-07 17:18:41 CEST
Created attachment 3061 
Fix LDFLAGS to LDADD and link to libxfcegui4
Comment 2 Fabian Nowak editbugs 2010-09-26 14:45:38 CEST
(In reply to comment #1)
> Created attachment 3061 
> Fix LDFLAGS to LDADD and link to libxfcegui4

the patch must be fixed to update configure.in.in instead for autogen.sh to run properly.
Comment 3 Samuli Suominen 2010-09-26 15:07:59 CEST
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 3061  [details]
> > Fix LDFLAGS to LDADD and link to libxfcegui4
> 
> the patch must be fixed to update configure.in.in instead for autogen.sh to run
> properly.

yeah, I rolled it against a tarball not git, sorry about that...
please apply the same changes to configure.in.in :)
Comment 4 Florian Rivoal editbugs 2010-11-05 15:23:31 CET
Patches applied. Thanks.

Bug #6616

Reported by:
Samuli Suominen
Reported on: 2010-08-07
Last modified on: 2010-11-05

People

Assignee:
Florian Rivoal
CC List:
2 users

Version

Version:
0.3.6 or older

Attachments

Detect both, new and old exo (728 bytes, patch)
2010-08-07 17:18 CEST , Samuli Suominen
no flags
Fix LDFLAGS to LDADD and link to libxfcegui4 (1.63 KB, patch)
2010-08-07 17:18 CEST , Samuli Suominen
no flags

Additional information