! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-diskperf-plugin-2.2.0 fails to build with xfce4-panel-4.7 (missing libx...
Status:
RESOLVED: FIXED
Product:
Xfce4-diskperf-plugin
Component:
General

Comments

Description Samuli Suominen 2010-08-07 13:28:55 CEST
Created attachment 3054 
Fix for libtool 2.2 and "xfce4-panel-4.7 issue"

First...

Missing AC_PROG_LIBTOOL() in configure.in (required by libtool-2.2). Otherwise autoconf bails out on:

configure:3995: error: possibly undefined macro: m4_ifval
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Need explicit libxfcegui4 cflags/libs because they wont come from xfce4-panel since 4.7 anymore, it's using libxfce4ui instead:

build.log:

https://bugs.gentoo.org/attachment.cgi?id=241753

xfce4_diskperf_plugin-main.o: In function `diskperf_create_options':
main.c:(.text+0x888): undefined reference to `xfce_err'
main.c:(.text+0x90a): undefined reference to `xfce_titled_dialog_new_with_buttons'
main.c:(.text+0x1045): undefined reference to `xfce_err'
xfce4_diskperf_plugin-main.o: In function `SetDevice':
main.c:(.text+0x1463): undefined reference to `xfce_err'

attached patch solves the issues
Comment 1 Landry Breuil editbugs 2010-08-08 08:57:00 CEST
AC_PROG_LIBTOOL() was already in configure.in.in in master.
Fixed for the other parts, thanks! (can someone close it ?)
Comment 2 Samuli Suominen 2010-08-08 09:16:16 CEST
thanks

Bug #6609

Reported by:
Samuli Suominen
Reported on: 2010-08-07
Last modified on: 2010-10-28

People

Assignee:
Xfce-Goodies Maintainers
CC List:
2 users

Version

Attachments

Fix for libtool 2.2 and "xfce4-panel-4.7 issue" (1.29 KB, application/octet-stream)
2010-08-07 13:28 CEST , Samuli Suominen
no flags

Additional information