! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
User's xfwm4rc more privileged than theme's
Status:
RESOLVED: MOVED
Severity:
enhancement

Comments

Description Denis 2010-07-17 20:13:59 CEST
Good time of day!

While using xfwm4 I faced one annoying problem: placement_ratio parameter wasn't saved through the sessions.

The problem was that the parameter (which was OK in xfconf and in user's xfwm4rc) was overwritten by theme's one at loading.

That's why I decided to write a patch, which makes user's xfwm4rc be more privileged than others.

I think it's safe because this file is not actively used for user's settings storage and will not make harm to general configuration.

The patch is attached.

Regards,
Denis.

P.S. Sorry for my English.
Comment 1 Mathias Brodala 2010-08-18 13:11:10 CEST
(In reply to comment #0)
> The patch is attached.

So where is it? :-)


Regards, Mathias
Comment 2 Denis 2010-08-18 14:34:31 CEST
Created attachment 3081 
xfwm4rc patch
Comment 3 Denis 2010-08-18 14:36:13 CEST
> So where is it? :-)

Sorry, I thought that I'd attached the patch. Now it's here.
Comment 4 Olivier Fourdan editbugs 2010-08-18 15:06:51 CEST
Well no, I disagree with that patch, the themerc takes precedence over everything else (themes can and do enforce button placement when not all placements or buttons are supported).

The problem is really with the theme you use, it should not fiddle with such settings, really.
Comment 5 Olivier Fourdan editbugs 2010-08-18 15:10:50 CEST
Well, the patch make it so only the user xfwm4rc takes precedence over themerc, so admittedly this is not going to cause much breakage (unless the user himself tweaked his xfwm4rc)...
Comment 6 Denis 2010-08-18 16:28:35 CEST
> (themes can and do enforce button placement when not all
> placements or buttons are supported).

Yeah, in such case this patch is useless.

> Well, the patch make it so only the user xfwm4rc takes precedence over themerc,
> so admittedly this is not going to cause much breakage (unless the user himself
> tweaked his xfwm4rc)...

I wrote it specially to ease life for advanced users, who know what are they doing. It makes code a bit more complicated, but it's safe, I think.
Comment 7 Git Bot editbugs 2020-05-29 11:44:29 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/43.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #6559

Reported by:
Denis
Reported on: 2010-07-17
Last modified on: 2020-05-29

People

Assignee:
Olivier Fourdan
CC List:
1 user

Version

Attachments

xfwm4rc patch (1.12 KB, patch)
2010-08-18 14:34 CEST , Denis
no flags

Additional information