! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
thunar-settings does nothing the first time if Thunar is not running yet
Status:
RESOLVED: FIXED

Comments

Description Martin Pitt 2010-07-08 09:17:06 CEST
In our project we do not launch Thunar by default on boot. With this, running "thunar-settings" does not bring up the settings dialog, it just dbus-activates "Thunar --daemon".

Once Thunar is running, launching thunar-settings a second time works fine then.
Comment 1 Martin Pitt 2010-07-08 09:25:08 CEST
Created attachment 3028 
git formatted patch

With this patch we keep the D-Bus connection open longer, which fixes the issue. While I was at it, I also made thunar-settings exit with nonzero if the call fails.
Comment 2 Jérôme Guelfucci editbugs 2010-09-03 08:11:46 CEST
Partially fixed in git master.

commit	c1f67c1b39af1c03ac3d31e95a35744670ecf354

Wait for a reply in thunar-settings.

If we don't do this the call fails when the thunar service is not running yet... Lame... 

I guess it would still be better to print an error and to return 1 if it fails.
Comment 3 Martin Pitt 2010-10-19 20:24:44 CEST
> I guess it would still be better to print an error and to return 1 if it fails.

... but that's exactly what my patch does? Or am I missing something?

Thanks,

Martin
Comment 4 Jannis Pohlmann editbugs 2010-11-13 17:59:58 CET
Yes, it is. Fixed in master:

commit 1a1d3f435bdc692b18f609e59796d596c5d9315c
Author: Jannis Pohlmann <jannis@xfce.org>
Date:   Sat Nov 13 17:59:24 2010 +0100

    Print an error if thunar-settings fails (bug #6547).

Bug #6547

Reported by:
Martin Pitt
Reported on: 2010-07-08
Last modified on: 2010-11-13

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

git formatted patch (1.25 KB, patch)
2010-07-08 09:25 CEST , Martin Pitt
no flags

Additional information