Created attachment 3019 
4.6.2 patch

Created attachment 3020 
git patch

Created attachment 3021 
uploaded wrong patch for git

Comment 4 Jérôme Guelfucci 2012-02-20 09:24:11 CET

Maybe a better way to solve this would be to use tumbler now that it provides thumbnails for the images on the desktop, it would avoid maintaining a second thumbnailing method and caching solution.

I'm adding Eric as cc, as he wrote the tumbler support for xfdesktop.

Comment 5 Eric Koegel 2013-02-17 17:15:15 CET

Created attachment 4923 
Add thumbnail service support to xfdesktop-settings

This patch adds support for using the thumbnail code in the settings app. Let me
know if you find someway to break it.

Comment 6 Jérôme Guelfucci 2013-02-24 20:51:46 CET

Your patch seems to work fine here, the first thumbnail takes a few seconds to appear though, the rest of them come really fast after that.

This is anyway definitely faster than the previous code. The fact that thumbnails are idle-loaded might look a bit weird, but loading all of them before opening the application is neither acceptable. Can you think about a better option?

Nice work!

Comment 7 Eric Koegel 2013-02-25 10:22:38 CET

Created attachment 4936 
Thumbnail service support to xfdesktop-settings

Thanks for testing it and the feedback.
This version should fix some of the initial delay. The intent of the timeout callback was only to pack a bunch of thumbnails in one thread rather than creating lots of threads. I tuned the timeout value down, I didn't intend to leave it that high. If this still is undesirable, I'll look into doing it another way.

Comment 8 Jérôme Guelfucci 2013-02-25 22:17:11 CET

The last patch is much faster. Here, the window appears then around one second later all thumbnails appear. Given that the window is useless without them, wouldn't it make sense to delay the window until we have enough thumbnails to fill the visible part of the icon view?

That would make the whole thing look more polished IMO.

Comment 9 Jérôme Guelfucci 2013-02-25 22:27:34 CET

In fact, the last patch does not work all the time. It may happen that the thumbnails don't appear (or only some of them) and that triggering an expose event is needed to get them shown.

Comment 10 Eric Koegel 2013-11-27 01:49:28 CET

With the merging of the eric/wallpaper-and-settings-improvements branch, xfdesktop-settings uses the dbus thumbnail service when available.