! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
panel doesn't recognize icon-themes on gtk 2.2
Status:
RESOLVED: WONTFIX
Product:
Xfce4-panel

Comments

Description Ilkka Ollakka 2005-01-03 17:27:11 CET
When compiling xfce4.2RC3 on gtk2.2 system, it seems that xfce4-panel can't use 
icon-themes (doens't find them?). Only error messages I get are this one in 
beginning: (xfce4-panel:17394): Gdk-CRITICAL **: file gdkdraw.c: line 411 
(gdk_draw_rectangle): assertion `GDK_IS_GC (gc)' failed 

and this one once a while on ~/.xsession-errors:
** (xfce4-panel:17394): WARNING **: No theme selected

I was using gtk 2.4 earlier than I think it worked on it (and tested on Suse 9.0 
with gtk 2.4, it works as expected)


Reproducible: Always
Steps to Reproduce:
1. 
2. 
3. 

Actual Results:  
Doesn't give any other error messages, icon themes are visible (you can select 
them) but icons doesn't change on panel or in ~/.config/xfce4/


GTK 2.2.4
GLib 2.2.3

Suse 9.1
Comment 1 Jasper Huijsmans editbugs 2005-01-03 19:22:13 CET
Brian, any ideas? This is not good and should be fixed.

Ilkka, does it show the default icons?
Comment 2 Brian J. Tarricone (not reading bugmail) 2005-01-03 19:32:12 CET
(In reply to comment #0)

> Doesn't give any other error messages, icon themes are visible (you can select 
> them) but icons doesn't change on panel or in ~/.config/xfce4/

what does that last part mean (about not changing in ~/.config/xfce4/)?  are you
saying that the setting isn't saved?  if so, this may be a separate issue,
unrelated to gtk.
Comment 3 Brian J. Tarricone (not reading bugmail) 2005-01-06 08:50:52 CET
Created attachment 141 
ui-plugin-icon-theme-gtk2.2fix.diff

reporter: could you please test this patch?  apply in xfce4/xfce-mcs-plugins
with 'patch -p0 < ui-plugin-icon-theme-gtk2.2fix.diff' and recompile and
install the pacakge.  let me know how it goes.
Comment 4 Ilkka Ollakka 2005-01-07 15:06:30 CET
I tested that patch and it didn't work :/

still getting error:
(xfce4-panel:28338): Gdk-CRITICAL **: file gdkdraw.c: line 411 
(gdk_draw_rectangle): assertion `GDK_IS_GC (gc)' failed

** (xfce4-panel:28338): WARNING **: No theme selected

And still ~/.config/xfce4/mcs_settings/panel.xml has wrong theme 
        <option name="theme" type="string" value="Rodent"/>

when ~/.config/xfce4/mcs_settings/gtk.xml has correct theme
        <option name="Net/IconThemeName" type="string" value="Industrial"/>

I was away for couple of days, sorry for delay on testing
Comment 5 Brian J. Tarricone (not reading bugmail) 2005-01-09 08:40:25 CET
the theme config in the panel.xml file is old and not used.  so it looks like
the theme data is getting saved, but gtk isn't listening.  which i guess makes
sense, since it doesn't really know to listen.  is there a way to tell gtk
globally to reload its theme data?  that might trigger an icon reload as well. 
maybe.  though anything that uses XfceIconTheme should change properly.

reporter: what happens when you change themes?  do you get any output from
xfce-mcs-manager?  the panel output is pretty irrelevant at this point, and i
don't think that error message you're seeing has anything to do with the icon
theming problem.  please kill and run xfce-mcs-manager from a terminal and look
at the output.  (do this with the patch applied.)
Comment 6 Ilkka Ollakka 2005-01-12 22:13:55 CET
I killed xfce-mcs-manager on kill -9 and then panel theme changed to
something different (on color,not icons, maybe default gtk-theme). when
started xfce-mcs-manager on terminal it doesn't give any output, but
I'll compile it on full-debug and see what it gives me then.

Oh, and when I change icon-theme nothing happens, but when I change
gtk-theme it changes instantly.

even with enable-debug=full xfce-mcs-manager doesn't give any error
messages, just messages on loading mcs-modules. Should I compile
everything related (libxfce*,xfce-mcs-plugins etc.) with
--enable-debug=full also ?
Comment 7 Ilkka Ollakka 2005-01-12 22:15:07 CET
sorry for late answering, didn't notice that I replied from wrong account.
Comment 8 Jasper Huijsmans editbugs 2005-05-08 15:19:23 CEST
I don't think we are going to fix this. I'm afraid we have to set priorities.
Thanks for the report.

Bug #653

Reported by:
Ilkka Ollakka
Reported on: 2005-01-03
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Attachments

ui-plugin-icon-theme-gtk2.2fix.diff (892 bytes, patch)
2005-01-06 08:50 CET , Brian J. Tarricone (not reading bugmail)
no flags

Additional information