! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Doesn't compile with git version of xfce4-panel
Status:
CLOSED: FIXED
Product:
Xfce4-netload-plugin
Component:
General

Comments

Description Alex Dedul 2010-05-22 17:57:02 CEST
When compiling netload plugin with xfce4-panel from git it writes this:

gcc -DPACKAGE_LOCALE_DIR=\"/usr/local/share/locale\" -pthread -I/usr/include/xfce4/libxfce4panel-1.0 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/xfce4 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14   -g -O2 -Wl,--export-dynamic -pthread -lxfce4panel-1.0 -lgtk-x11-2.0 -lxfce4util -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0    -o xfce4-netload-plugin xfce4_netload_plugin-netload.o xfce4_netload_plugin-utils.o xfce4_netload_plugin-net.o  
xfce4_netload_plugin-netload.o: In function `setup_monitor':
/home/plisk/tmp/xfce4-netload-plugin/panel-plugin/netload.c:468: undefined reference to `xfce_err'
xfce4_netload_plugin-netload.o: In function `monitor_create_options':
/home/plisk/tmp/xfce4-netload-plugin/panel-plugin/netload.c:849: undefined reference to `xfce_titled_dialog_new_with_buttons'
collect2: ld returned 1 exit status
make[2]: *** [xfce4-netload-plugin] Error 1

A bit of googling suggested to add libxfcegui4 to linking flags and with it compiles and works okay. Attaching trivial patch with this.
Comment 1 Alex Dedul 2010-05-22 17:58:15 CEST
Created attachment 2990 
Patch to fix linking
Comment 2 Florian Rivoal editbugs 2010-10-14 17:42:57 CEST
Thanks for the patch, I just applied it to the master branch.
Comment 3 Florian Rivoal editbugs 2010-10-14 17:46:30 CEST
*** Bug 6622 has been marked as a duplicate of this bug. ***
Comment 4 Florian Rivoal editbugs 2010-10-14 17:47:23 CEST
*** Bug 2782 has been marked as a duplicate of this bug. ***

Bug #6466

Reported by:
Alex Dedul
Reported on: 2010-05-22
Last modified on: 2012-01-13
Duplicates (2):
  • 2782 Fix xfce4-netload-plugin-0.4.0 building with -Wl,--as-needed [PATCH]
  • 6622 xfce4-netload-plugin-0.4.0 fails to compile with xfce4-panel-4.7 (missing libxfcegui4 linking)

People

Assignee:
Bernhard Walle
CC List:
2 users

Version

Attachments

Patch to fix linking (1.02 KB, patch)
2010-05-22 17:58 CEST , Alex Dedul
no flags

Additional information