! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Notification appears more in the middle of the screen than bottom-right
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description Mike Massonnet editbugs 2010-04-10 18:43:19 CEST
The xfce4-notify bubbles are configured to bottom-right (same happens with top-right) but don't appear on the right side of the display. This is caused by a panel that is running on the bottom right corner. However when the panel gets wider the bubbles will finally appear right at the edge of the screen.
Comment 1 Mike Massonnet editbugs 2010-04-10 18:43:53 CEST
Created attachment 2927 
Missaligned
Comment 2 Mike Massonnet editbugs 2010-04-10 18:44:31 CEST
Created attachment 2928 
Well aligned (panel is a little wider)
Comment 3 Brian J. Tarricone (not reading bugmail) 2010-04-10 21:16:05 CEST
Can you paste output of "xprop | grep STRUT" for each of your panels?
Comment 4 Brian J. Tarricone (not reading bugmail) 2010-04-10 21:17:14 CEST
Rather, can you do that twice -- once for each panel in the "doesn't work right" case, and once for each panel in the "works right" case... and be sure to note which set of numbers goes for which panel in each case.
Comment 5 Mike Massonnet editbugs 2010-04-11 04:28:55 CEST
For the top panel the result is always he same:
_NET_WM_STRUT_PARTIAL(CARDINAL) = 0, 0, 29, 0, 0, 0, 0, 0, 0, 1024, 0, 0


For the bottom panel:
Missaligned:
_NET_WM_STRUT_PARTIAL(CARDINAL) = 0, 0, 0, 33, 0, 0, 0, 0, 0, 0, 758, 1024


Well aligned:
_NET_WM_STRUT_PARTIAL(CARDINAL) = 0, 0, 0, 33, 0, 0, 0, 0, 0, 0, 583, 1024
Comment 6 Brian J. Tarricone (not reading bugmail) 2010-04-11 07:03:19 CEST
Hmm, weird.  That looks right.  Sounds like maybe the workarea calculation stuff is getting confused by something.  Jerome, any chance you can take a look?
Comment 7 Jérôme Guelfucci editbugs 2010-04-11 08:58:52 CEST
Yep, I'll try to have a look when I find some time.
Comment 8 Jérôme Guelfucci editbugs 2010-04-12 22:25:46 CEST
Created attachment 2934 
Patch to fix the issue? Or not?

Mike, could you please test this patch?

I totally reworked the function. I had taken this code from I don't remember where, it's late and I could not understand it so I rewrote everything with a simpler algorithm. Looking at the number of MAX and if, the complexity should be roughly the same, and at least I understand my code now ^^

Let me know if this works.

Brian: you'll notice some "wonderful" artwork in the code comments, I think it eases the understanding of the code, but feel free to remove it. Maybe I could add some additional "artwork" to explain what I mean by "rectangles implied by dx" but once you draw the rest of the thing it's easy to understand.
Comment 9 Mike Massonnet editbugs 2010-04-13 06:51:59 CEST
Works fine for me. When the panel is auto-hidden it displays right in the corner, and when the panel is not set to auto-hide it displays well too and not right in the corner as otherwise it would overlap.
Comment 10 Jérôme Guelfucci editbugs 2010-11-07 13:33:23 CET
Fixed in git master.

Bug #6380

Reported by:
Mike Massonnet
Reported on: 2010-04-10
Last modified on: 2010-11-07

People

Assignee:
Jérôme Guelfucci
CC List:
0 users

Version

Version:
unspecified

Attachments

Missaligned (749.75 KB, image/png)
2010-04-10 18:43 CEST , Mike Massonnet
no flags
Well aligned (panel is a little wider) (771.37 KB, image/png)
2010-04-10 18:44 CEST , Mike Massonnet
no flags
Patch to fix the issue? Or not? (3.84 KB, patch)
2010-04-12 22:25 CEST , Jérôme Guelfucci
no flags

Additional information