! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch]Port xfce4-notifyd to libxfce4ui and GtkBuilder
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-notifyd
Component:
general

Comments

Description Skunnyk 2010-04-10 11:23:17 CEST
Created attachment 2921 
Port to libxfce4ui and GtkBuilder

In attachment, a patch to port the xfce4-notifyd component (git version) to libxfce4ui and GtkBuilder.
Comment 1 Skunnyk 2010-04-10 11:49:25 CEST
Created attachment 2922 
Port to libxfce4ui and GtkBuilder
Comment 2 Mike Massonnet editbugs 2010-04-10 18:05:18 CEST
Applied fine, clean patch :)
Comment 3 Brian J. Tarricone (not reading bugmail) 2010-04-10 21:08:35 CEST
Coding style issues with function arg alignment in the 2 calls to gtk_icon_theme_load_icon() in that patch.  Please fix.

GTK_ICON_LOOKUP_FORCE_SIZE is only available in gtk 2.14 and later, but configure.ac.in only specifies gtk 2.10.0 as a requirement.  Since this isn't a critical feature, please add the following to the top of the 2 files that use this:

#if !GTK_CHECK_VERSION(2, 14, 0)
#define GTK_ICON_LOOKUP_FORCE_SIZE  0
#endif

The committer author says "Sunnyk" as the name.  Please re-commit with a full name.

With these fixes, I'd be happy to check your patch in.
Comment 4 Jérôme Guelfucci editbugs 2010-04-11 12:13:24 CEST
Brian: libxfce4ui already depends on gtk 2.14, so why don't we bump the required gtk version to 2.14 too, that will not change anything, right?
Comment 5 Brian J. Tarricone (not reading bugmail) 2010-04-11 13:01:50 CEST
That's a shame, but I suppose can't be helped.  Reporter: in that case, please update configure.ac.in as well in the next version of the patch.
Comment 6 Skunnyk 2010-04-11 15:54:29 CEST
Created attachment 2932 
Port to libxfce4ui and GtkBuilder

New version of patch with consideration of comments (coding style, bump gtk version etc). Hope all is ok.
Comment 7 Brian J. Tarricone (not reading bugmail) 2010-04-12 00:53:10 CEST
Works great here.  Patch checked in as rev f1169d8.  Thanks so much!

Bug #6375

Reported by:
Skunnyk
Reported on: 2010-04-10
Last modified on: 2010-04-12

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
3 users

Version

Attachments

Additional information