! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Terminal-0.4.4 does not respect SHELL
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Fabian Groffen 2010-04-06 11:59:41 CEST
Created attachment 2918 
use SHELL before pw_shell

After the patch from bug http://bugzilla.xfce.org/show_bug.cgi?id=4970, Terminal now uses SHELL as fall-back when nothing was returned from getpwuid.  However, this behaviour favours the shell as set in the user's account over the SHELL setting in the environment.

xterm and gnome-term seem to respect this variable when they find the shell to spawn, Terminal however does not.  As a result, a user who set SHELL=/my/own/shell and starts Terminal, will not get this shell, but instead the one from the user's account record (which isn't always under control by the user).

The attached patch prioritises honouring SHELL over what's in the user's account.  The patch works for me, and makes Terminal behave like xterm and gnome-term do, starting the right shell, and hence ending up in the right environment.
Comment 1 Nick Schermer editbugs 2010-05-20 19:55:59 CEST
Fixed in a86b61b. See the commit for more information about the changes.

Bug #6368

Reported by:
Fabian Groffen
Reported on: 2010-04-06
Last modified on: 2010-05-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

use SHELL before pw_shell (1.55 KB, patch)
2010-04-06 11:59 CEST , Fabian Groffen
no flags

Additional information