! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfdesktop-settings from git core dumps on large amount of images or subdirs?
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description Unnamed_Hero 2010-04-01 12:47:09 CEST
Created attachment 2915 
strace xfdesktop-settings

I've symlinked /usr/share/wallpapers  (kde wallpapers here) to /usr/share/xfce4/backdrops, and when I launch xfdestop-settings - it coredumps. There are a lot of subdirs in that folder, and there are dozen of images in that dir.
All xfce from git @ 30th march.

folder looks like this
blah1
|_contents
  |_images
    |_img_800x600.png
    |_img_1024x768.png
....
blah20
|_(same as above}
...
|_some_image.png
|_other_image.png
....
|_last_image.png
Comment 1 dylix98 2010-07-03 04:03:36 CEST
Created attachment 3022 
xfdesktop-common.c patch

same problem here .. when its testing for valid images doesnt bother to check if its a directory that its trying to add and not a file.. 

fix included..
Comment 2 Eric Koegel editbugs 2013-12-03 07:30:53 CET
Sorry I missed this patch in the past. Xfdesktop has been changed in how it checks if the file is a valid image using the formats provided by gdk_pixbuf_get_formats which will fix this issue.

Bug #6356

Reported by:
Unnamed_Hero
Reported on: 2010-04-01
Last modified on: 2013-12-03

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Version:
Unspecified

Attachments

strace xfdesktop-settings (17.17 KB, application/gzip)
2010-04-01 12:47 CEST , Unnamed_Hero
no flags
xfdesktop-common.c patch (690 bytes, patch)
2010-07-03 04:03 CEST , dylix98
no flags

Additional information