! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
GUI enhancements and about-dialog
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-time-out-plugin
Component:
General

Comments

Description Fabian Nowak editbugs 2010-03-28 10:35:30 CEST
Hey,
I propose to left-align the labels in the settings dialog in the upper part. Also, the about dialog does not show up when selected in the plugin's context menu.
Comment 1 Florian Rivoal editbugs 2010-11-11 16:36:02 CET
For the about dialog, that's been fixed recently, see Bug 4287

I'll leave this bug open to deal with the other part of the request.
Comment 2 Landry Breuil editbugs 2014-11-23 21:42:37 CET
Mass-reassign all bugs from florian@ to goodies-dev@, thanks for the maintenance work! (and sorry for the bugmail spam..)
Comment 3 Iris Ilexiris 2017-11-24 21:14:47 CET
Created attachment 7445 
Left-align labels for time settings

Turns out tables need GTK_FILL for xoptions (in gtk_table_attach()) in order to be able to horizontally align cell content to anything but the center. Makes a lot of sense, I guess.

The labels themselves were right aligned (but effectively centered because of the xoption arg), so I'm guessing the original author intended them to be just that, but I decided to go for Fabian's request in the end.
Comment 4 Git Bot editbugs 2017-11-29 09:51:50 CET
Iris Ilexiris referenced this bugreport in commit 262e666865a4894a3f54ce792d8d7b7cba2ad550

Left-align labels for time settings (bug #6346)

https://git.xfce.org/panel-plugins/xfce4-time-out-plugin/commit?id=262e666865a4894a3f54ce792d8d7b7cba2ad550
Comment 5 Landry Breuil editbugs 2017-11-29 09:52:35 CET
Thanks, pushed ! Note that for a migration to Gtk3 one should use GtkGrid instead of the deprecated GtkTable but that's another story :)

Bug #6346

Reported by:
Fabian Nowak
Reported on: 2010-03-28
Last modified on: 2017-11-29

People

Assignee:
Xfce-Goodies Maintainers
CC List:
3 users

Version

Version:
0.1.1 or older

Attachments

Left-align labels for time settings (1.70 KB, patch)
2017-11-24 21:14 CET , Iris Ilexiris
iris.ilexiris : review+

Additional information