Hey, I have a weird bug in Terminal (0.4.4 and 0.4.3 at least). All the “text” properties are reset to none when closing the preferences files: Term WordChars TitleInitial The behavior seems recent but I can't see when it occurred. It might be related to a GTK+ upgrade though.
When trying to debug, I've added printf() to terminal_screen_update_word_chars() and here is the result: ---- corsac@hidalgo: terminal/Terminal (Terminal:16439): Terminal-DEBUG: D-Bus reply error: Name "org.xfce.Terminal3" does not exist (terminal-error-quark: 3) (Terminal:16439): Terminal-DEBUG: Monitoring "/home/corsac/.config/Terminal/terminalrc" for changes. debug: word_chars = -A-Za-z0-9,./?%&#:_~+ // terminal is started // preferences window is opened // preferences window is closed debug: word_chars = debug: word_chars = ---- So it seems that the swapped-signal::notify::word-chars signal is called with an empty parameter twice when closing the preferences window. GTK+ is 2.18.9-1
It doesn't seem to happen on my Debian testing box which uses GTK+ 2.18.6 so I'll try to downgrade
Ok, confirmed, downgrading GTK+ to 2.18.6 fixes the problem.
I've reported GTK+ bug 613489 (https://bugzilla.gnome.org/show_bug.cgi?id=613489) Basically it seems that using 2.18.9 the signal is sent twice when closing preferences window, and by that time the string returned by the g_object_get() is empty (but not NULL)
Adding a check for strlen() >0 seems to workaround in terminal_screen_update_word_chars() but it'll still store the value in the config file, I guess because of the BIND_PROPERTY() found in terminal-preferences.c
Created attachment 2900 Disconnect bindings before dialog close Could one of you folks try this patch?
Rewriting the file is normal. It avoid corrupted files (write tmp file, on succeed unlink old config and rename the tmp file). Although this is obviously a bug in gtk, it is not too hard to work around it.
patch seems to work fine against master. Any chance you could comment on GTK+ bug?
And any chance to push a release so 0.4.4 would contain the various “binary renaming” fixes and that one?
No idea, they're fiddling around with the entry buffer a lot lately. Have to look at the status of the renaming stuff, do you have any remaining issues? Else I can release a new version.
(might be easier on IRC :)(In reply to comment #10) > No idea, they're fiddling around with the entry buffer a lot lately. Yeah, on the GTK+ bug I've added a comment, it seems related to http://bugzilla.gnome.org/612505 > > Have to look at the status of the renaming stuff, do you have any remaining > issues? Else I can release a new version. At the moment it seems I'm manually renaming manpages and the .desktop file. Glade/gtkbuilder files are also named Terminal.glade in /usr/share/Terminal but the filename is hardcoded in the source afaics.
Workaround for people running into this issue, until fixed GTK+ or a workaround Terminal package appears: * revert your .config/Terminal/terminalrc: TitleInitial=Terminal Term=xterm WordChars=-A-Za-z0-9,./?%&#:_~+ * don't go back to the preferences until it's fixed
*** Bug 6398 has been marked as a duplicate of this bug. ***