Tried this on Debian & Ubuntu only, but it seems whenever the settings are changed from a 24 to a 12 hour clock, the change doesn't survive a reboot.
Works fine here. Could you look if the ShowMilitary key is changing in the clock config file? File location is ~/.config/xfce4/panel/clock-???.rc.
Not valid anymore for Xfce 4.7.