! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Doesn't check audio info validity before using the file
Status:
RESOLVED: FIXED
Product:
Thunar-media-tags-plugin
Component:
General

Comments

Description Lionel Le Folgoc 2010-03-07 19:49:20 CET
Created attachment 2879 
proposed patch

Hi,

To determine if a file is supported, the plugin checks that the file returned by taglib_file_new() isn't NULL. But apparently this is not sufficient, as it would return non NULL even for weird ogg video files (because ogg is a supported filetype), and trying to display tags from them would fail, and crash thunar.

The attached patch calls taglib_file_is_valid() on the obtained taglib_file, to ensure that its audio metadata are really valid, and can be displayed/queried/changed by thunar without risk.
Comment 1 Nick Schermer editbugs 2011-11-30 18:27:04 CET
Applied.

Bug #6297

Reported by:
Lionel Le Folgoc
Reported on: 2010-03-07
Last modified on: 2011-11-30

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

proposed patch (1.00 KB, patch)
2010-03-07 19:49 CET , Lionel Le Folgoc
no flags

Additional information