! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
garbage displayed in “GMT Offset” in timezone config
Status:
CLOSED: FIXED

Comments

Description Yves-Alexis Perez editbugs 2010-03-06 10:13:23 CET
Hey,

trying to reconfigure my orage clock panel plugin, I looked at the new TZ configuration stuff, and it displays garbage at the GMT offset.

Nothing crashes, but it doesn't look good, especially if it's memory stuff which is displayed there.

A screenshot is attached.
Comment 1 Yves-Alexis Perez editbugs 2010-03-06 10:13:43 CET
Created attachment 2876 
screenshot of the problem
Comment 2 Yves-Alexis Perez editbugs 2010-03-06 10:14:34 CET
Oh, and clicking on “change mode” crashes the plugin
Comment 3 juha editbugs 2010-03-08 14:14:57 CET
I can reproduce this.
Comment 4 juha editbugs 2010-03-09 03:53:09 CET
Well, I could reproduce the crash, but not the garbage.

I believe you get the same results from orage timezone selection also?

Would you have time to modify debug variable to value 4 in tz_zoneinfo_read.c:
static int debug = 4; /* bigger number => more output */

and then run orage like:
orage > test.txt

and send the test.txt to me. It will be fairly big.






the crash should be fixed by modifying tz_zoneinfo_read.c:

Add
    in_file = NULL;

After line 605:

static int check_parameters()
{
    char *s_tz, *last_tz = NULL, tz[]="/zoneinfo", tz2[]="zoneinfo/";
    int tz_len, i;
    struct stat in_stat;
    FILE *par_file;
    struct stat par_file_stat;

    if (debug > 1)
        printf("check_parameters: start\n");

    in_file = NULL;
    par_file = fopen(TZ_CONVERT_PAR_FILE_LOC, "r");
    if (par_file != NULL) { /* does exist and no error */
Comment 5 juha editbugs 2010-03-11 09:37:35 CET
crash fixed in GIT in Orage 4.7.5.17.

Can't reproduce the garbage though.
Comment 6 juha editbugs 2010-12-08 22:44:55 CET
I get the garbage now in my 64 bit test environment.
Comment 7 juha editbugs 2010-12-10 15:35:27 CET
Finally fixed that in Orage 4.7.6.3. Available in git. This only happened in systems where long was more then 4 bytes wide.
Comment 8 juha editbugs 2011-01-18 14:20:40 CET
in 4.8.0

Bug #6290

Reported by:
Yves-Alexis Perez
Reported on: 2010-03-06
Last modified on: 2011-01-18

People

CC List:
0 users

Version

Attachments

screenshot of the problem (63.13 KB, image/png)
2010-03-06 10:13 CET , Yves-Alexis Perez
no flags

Additional information