! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
background does not respect gtk theme for external plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Jérôme Guelfucci editbugs 2010-03-02 06:59:56 CET
I'm using Shiki-Wise as a gtk theme and the notification area does not have the same background as the rest of the panel. This used to work fine in xfce4-panel 4.6.x.

See the screenshot attached.
Comment 1 Nick Schermer editbugs 2010-03-02 19:59:20 CET
Mm that's odd. Will get my glasses first to look at the attachment first (<- hint)...
Comment 2 Jérôme Guelfucci editbugs 2010-03-02 21:01:03 CET
Created attachment 2867 
Screenshot

Sorry...
Comment 3 Mike Massonnet editbugs 2010-03-03 18:51:12 CET
I'm using the GTK+ theme "dust"[0] and I notice the exact same problem, but it looks like it is not related to the notification icon but more generally to external plugins. I have tested the notes plugin which runs inside the wrapper and I notice the same problem -- note that the nofication icon also runs in the wrapper -- so the problem is the background is as the default window background color (grey) instead of the panel color (black). These themes use different background colors, one for the main window, and one for the menubar/toolbar and for the panel too.

[0] https://launchpad.net/dusttheme

From the gtkrc file of the theme these lines that are relevant:

# Panel stuff
widget "*PanelWidget*"              style "panel"
widget "*PanelApplet*"              style "panel"
widget "*fast-user-switch*"         style "panel" # Workaround for Fast User Switch applet
class "PanelApp*"                   style "panel"
class "PanelToplevel*"              style "panel"
widget_class "*Panel*<GtkMenuBar>*" style:highest "panel" # The panel menubar
widget "*TomboyTray*"               style "panel" # Workaround for Tomboy
widget "*TomboyApplet*"             style "panel"

#XFCE panel
widget_class "*notif*"          style "panel"
widget_class "*Notif*"          style "panel"
widget_class "*Tray*"           style "panel"
widget_class "*tray*"           style "panel"
widget "*Xfce*Panel*"           style "panel"
class "*Xfce*Panel*"            style "panel"

Not sure if the wrapper application has a widget, but if than it can perhaps be named to "XfcePanelPlugin" and it may fix this problem, not exactly sure however...
Comment 4 Mike Massonnet editbugs 2010-03-03 18:54:31 CET
Created attachment 2868 
Other screenshot

PS: the dust theme is available in Archlinux under gtk2-theme-dust and gtk2-theme-dust-extras (I'm using "Dust Burnt" currently from -extras)
Comment 5 Nick Schermer editbugs 2010-03-03 19:44:58 CET
Much simpler then that, the wrapper had not a proper theme name. Should be fixed now.
Comment 6 Mike Massonnet editbugs 2010-03-05 01:57:41 CET
I found out one case where the background colour is not correct, for an auto-hidden panel. When the panel is hidden it will pick up a light grey colour instead of the dark black one.
Comment 7 Nick Schermer editbugs 2010-03-05 17:44:06 CET
Fixed that too. The widget names are now XfcePanelWindow, XfcePanelWindowHidden, XfcePanelWrapper.
Comment 8 Nick Schermer editbugs 2010-03-05 17:47:29 CET
Renamed the 4.6 plugins to XfcePanelWindowExternal, and wrapper to XfcePanelWindowWrapper. Now everything will match XfcePanelWindow* (they all have GtkWindow as parent, so it makes sense).

Bug #6268

Reported by:
Jérôme Guelfucci
Reported on: 2010-03-02
Last modified on: 2010-03-05

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
4.7 (master)

Attachments

Screenshot (8.60 KB, image/png)
2010-03-02 21:01 CET , Jérôme Guelfucci
no flags
Other screenshot (15.00 KB, image/png)
2010-03-03 18:54 CET , Mike Massonnet
no flags

Additional information