! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add slock functionality
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Xfce-utils
Component:
General

Comments

Description Evaggelos Balaskas 2010-02-25 12:17:07 CET
Add slock[0] (a Simple X display locker) functionality to xflock4 script

File: xfce-utils/scripts/xflock4

Patch:

--- xflock4	2009-10-14 14:52:56.114312329 +0300
+++ xflock4.slock	2010-02-25 14:05:59.094354611 +0200
@@ -23,6 +23,8 @@
     xscreensaver-command -lock 
 elif test x"`which gnome-screensaver-command 2>/dev/null`" != x""; then
     gnome-screensaver-command --lock
+elif test x"`which slock 2>/dev/null`" != x""; then
+    slock
 else
     xlock $*
 fi


[0]: http://tools.suckless.org/slock
Comment 1 Nick Schermer editbugs 2010-02-25 12:48:27 CET
Applied in 306869d18a9bb3e87ca67f1ac825560fd4454e62.
Comment 2 Olivier Fourdan editbugs 2010-02-25 12:53:14 CET
Err, do we really want to support "slock"?

I find it very confusing, it doesn't display even a prompt, so that one has to type blindly the password to unlock the screen (or am I missing something?)
Comment 3 Evaggelos Balaskas 2010-02-25 13:01:21 CET
but there isnt anything xfce team have to support.

It is an external program like xscreensaver or gnome-screensaver.
With ctl+alt+del xflock4 is enabled and it would be nice to enable screen lock with any of lockers a user maybe have.

Isnt that the idea behind xflock4 ?
Comment 4 Yves-Alexis Perez editbugs 2010-02-25 13:58:12 CET
Maybe there should be some kind of fallback to what the user decided to use, but the script can't support each and every screenlocker, imho.

And yes, by adding them to xflock4, we are kind of promoting their use in Xfce, which means we do support them, in a way.
Comment 5 Nick Schermer editbugs 2010-02-25 14:05:21 CET
You install these kind of locking tools on purpose, so I didn't seen any problems with it. However we could add a environment variable fallback, so you only have to put XFLOCK4_COMMAND in your bash profile for alternative apps?
Comment 6 Robby Workman editbugs 2010-02-25 14:15:12 CET
*** Bug 5121 has been marked as a duplicate of this bug. ***

Bug #6253

Reported by:
Evaggelos Balaskas
Reported on: 2010-02-25
Last modified on: 2012-04-18
Duplicates (1):
  • 5121 Add slock as an option in xflock4 script

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
Unspecified

Attachments

Additional information