! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[patch] add support for <br> tag for multiline notifications
Status:
RESOLVED: WONTFIX
Product:
Xfce4-notifyd
Component:
general

Comments

Description Unnamed_Hero 2010-02-21 19:32:53 CET
I have wrote a patch, which parses body message for <br> tag, replaces it for "\n", and cast a g_strcompress on it. And now we have multiline notifications. 

I'm not so skilled in c/gtk, but, suddenly, it works;
Comment 1 Unnamed_Hero 2010-02-21 19:33:57 CET
Created attachment 2856 
br_patch
Comment 2 Unnamed_Hero 2010-02-21 19:46:56 CET
(In reply to comment #1)
> Created an attachment (id=2856) [details]
> br_patch

Oops, these need some more workarounds.
Comment 3 Unnamed_Hero 2010-02-21 19:59:55 CET
Created attachment 2857 
good br_patch
Comment 4 Brian J. Tarricone (not reading bugmail) 2010-02-22 00:51:41 CET
The <br> tag isn't allowed by the spec:
http://galago-project.org/specs/notification/0.9/x161.html
Comment 5 Unnamed_Hero 2010-02-22 08:25:52 CET
knotify from Kde, and Canonical notify-osd support it. I think it's a good idea to have support for such things. No one force using it.
Comment 6 Brian J. Tarricone (not reading bugmail) 2010-02-22 12:35:19 CET
The problem is that it's not in the spec, and if a few implementations support it, application authors come to expect it, even though it's not standard.  This is one reason why writing HTML sucks.

Bug #6247

Reported by:
Unnamed_Hero
Reported on: 2010-02-21
Last modified on: 2010-02-22

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Version:
unspecified

Attachments

br_patch (1.89 KB, application/octet-stream)
2010-02-21 19:33 CET , Unnamed_Hero
no flags
good br_patch (1.97 KB, application/octet-stream)
2010-02-21 19:59 CET , Unnamed_Hero
no flags

Additional information