! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-settings-4.6.4 doesn't build with new libxklavier 5.0
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
General

Comments

Description Kevin Fenzi 2010-01-21 22:34:43 CET
You can see the entire build log in the fedora build system: 

http://koji.fedoraproject.org/koji/getfile?taskID=1928918&name=build.log

From the end of it: 

gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -DDATADIR=\"/usr/share\" -DBINDIR=\"/usr/bin\" -DSRCDIR=\"../..\" -DLOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"xfce4-keyboard-settings\" -DNDEBUG -DG_DISABLE_CAST_CHECKS   -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2    -I/usr/include/xfce4 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread -I/usr/include/xfce4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/atk-1.0   -pthread -I/usr/include/xfce4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/xfce4/xfconf-0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include   -pthread -I/usr/include/exo-0.3 -I/usr/include/gtk-2.0 -I/usr/include/xfce4 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I/usr/include/xfce4/xfconf-0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -MT xfce4_keyboard_settings-command-dialog.o -MD -MP -MF .deps/xfce4_keyboard_settings-command-dialog.Tpo -c -o xfce4_keyboard_settings-command-dialog.o `test -f 'command-dialog.c' || echo './'`command-dialog.c
LC_ALL=C /usr/bin/intltool-merge -d -u -c ../../po/.intltool-merge-cache ../../po xfce-keyboard-settings.desktop.in xfce-keyboard-settings.desktop
Found cached translation database
Merging translations into xfce-keyboard-settings.desktop.
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_finalize':
xfce-keyboard-settings.c:460: error: too few arguments to function 'xkl_engine_stop_listen'
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_update_sensitive':
xfce-keyboard-settings.c:1081: warning: 'return' with no value, in function returning non-void
xfce-keyboard-settings.c:1082: warning: 'return' with no value, in function returning non-void
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_system_default_cb':
xfce-keyboard-settings.c:1100: warning: unused variable 'xkb_layout_frame'
xfce-keyboard-settings.c:1099: warning: unused variable 'xkb_model_frame'
mv -f .deps/xfce4_keyboard_settings-main.Tpo .deps/xfce4_keyboard_settings-main.Po
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_add_layout_button_cb':
xfce-keyboard-settings.c:1416: warning: unused variable 'selection'
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_add_variant_to_list':
xfce-keyboard-settings.c:1469: warning: unused variable 'model'
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_add_layout_to_list':
xfce-keyboard-settings.c:1493: warning: unused variable 'iter'
xfce-keyboard-settings.c:1492: warning: unused variable 'model'
xfce-keyboard-settings.c: In function 'xfce_keyboard_settings_layout_selection':
xfce-keyboard-settings.c:1537: warning: unused variable 'selected_iter'
xfce-keyboard-settings.c:1529: warning: unused variable 'layout_selection_cancel_button'
xfce-keyboard-settings.c:1528: warning: unused variable 'layout_selection_ok_button'
make[4]: *** [xfce4_keyboard_settings-xfce-keyboard-settings.o] Error 1
make[4]: *** Waiting for unfinished jobs....
mv -f .deps/xfce4_keyboard_settings-command-dialog.Tpo .deps/xfce4_keyboard_settings-command-dialog.Po
make[4]: Leaving directory `/builddir/build/BUILD/xfce4-settings-4.6.4/dialogs/keyboard-settings'
make[3]: Leaving directory `/builddir/build/BUILD/xfce4-settings-4.6.4/dialogs/keyboard-settings'
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/xfce4-settings-4.6.4/dialogs'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/xfce4-settings-4.6.4'
make: *** [all] Error 2

xfce4-settings-4.6.4
libxklavier-5.0
Comment 1 Lionel Le Folgoc 2010-01-25 20:29:56 CET
Created attachment 2794 
Proposed patch

This patch fixes the build for me: it adds the same flag as passed in xkl_engine_start() (I don't use libxklavier 5.0 yet, so I don't know if it really works, but I can't see any reason for it not to).
Comment 2 Lionel Le Folgoc 2010-01-25 21:38:14 CET
Created attachment 2795 
Proposed patch

This one is probably better, with the correct version check.
Comment 3 Christoph Wickert editbugs 2010-01-26 00:08:09 CET
Tested and works.
Comment 4 Jérôme Guelfucci editbugs 2010-01-26 21:53:01 CET
The patch works fine for me (libxklavier4) and for Christoph (libxklavier5). Pushed to master.

Bug #6175

Reported by:
Kevin Fenzi
Reported on: 2010-01-21
Last modified on: 2010-01-26

People

Assignee:
Stephan Arts
CC List:
5 users

Version

Attachments

Proposed patch (947 bytes, patch)
2010-01-25 20:29 CET , Lionel Le Folgoc
no flags
Proposed patch (1.68 KB, patch)
2010-01-25 21:38 CET , Lionel Le Folgoc
no flags

Additional information