When I built xffm (and also libxfce4util and libxfce4mcs), I configured it in another directory, like: mkdir builddir cd builddir ../xffm_src_dir/configure make It will stop with an error (forgor what error, but something about missing includes). I've determined that this bug is caused by the DEFAULT_INCLUDES variable, in src/Makefile.in for xffm, in libxfce4mcs/Makefile.in for libxfce4util, and in xfce4-kiosk-query/Makefile.in for libxfce4util. This bug is still present in today's CVS. Reproducible: Always Steps to Reproduce: 1. Just look for the variable "DEFAULT_INCLUDES" in each Makefile 2. Read the value assigned to it 3. Actual Results: DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_builddir) Expected Results: DEFAULT_INCLUDES = -I. -I$(top_srcdir) -I$(top_builddir)
Created attachment 126 My patch for this bug that fixes xffm in 4.1.99.2
Created attachment 127 Same as previous patch, for libxfce4util 4.1.99.2
Created attachment 128 Same as previous patch, for libxfce4mcs 4.1.99.2
unfortunately you have to patch Makefile.am, not Makefile.in, because Makefile.in is an autogenerated file. the Makefile.am files in those directories are correct, and they build correctly for me using the method you describe. well, ok, i only tried libxfce4mcs, but that worked fine. please give the exact error message, otherwise it's unlikely we can help you.
Benny, Would it be ok to apply the patches to libxfce4uitl and libxfcemcs?
(In reply to comment #5) > Would it be ok to apply the patches to libxfce4uitl and libxfcemcs? there isn't much of a point, since the next time someone runs autogen, the changes get blown away again. at any rate, it works fine here. edscott, did you try it (without the patch)?
Right, you need to change the INCLUDES in Makefile.am instead.
(In reply to comment #7) > Right, you need to change the INCLUDES in Makefile.am instead. no one seems to be paying attention ^_~. there is *no error* in our Makefile.am files. we don't erroneously add -I$(srcdir) to INCLUDES. perhaps we *should* be adding -I$(top_srcdir) at some point, but this works fine for me without that. i'm not sure why the reporter is seeing this problem, since config.status should be generating the same Makefiles, regardless of what version of the autotools are on his system.
Created attachment 132 My build script for libxfce4mcs Sorry for not replying earlier. This is the script I use to build libxfce4mcs. My autoconf is 2.59 and automake is 1.9.1 (maybe I should upgrade to 1.9.4? but the testsuite failed :( )
Oh well, seems like they're all fixed: http://cvs.xfce.org/viewcvs.cgi/xfce4/xffm/src/Makefile.am?r1=1.66&r2=1.67 http://cvs.xfce.org/viewcvs.cgi/xfce4/libxfce4mcs/libxfce4mcs/Makefile.am?r1=1.10&r2=1.11 http://cvs.xfce.org/viewcvs.cgi/xfce4/libxfce4util/xfce4-kiosk-query/Makefile.am?r1=1.1&r2=1.2 Sorry, I didn't know it was Makefile.am that was responsible (I've never touched automake before, except compiling and installing it :P). Thanks :)