Description Adam Plumb 2009-12-17 19:45:18 CET

Created attachment 2748 
Patch file

This may be be design, so please excuse me if it is.

In thunar-file.c, thunar_file_monitor_file_changed is called twice when it should only be called once.

    static void
    thunar_file_info_changed (ThunarxFileInfo *file_info)
    {
      thunar_file_set_thumb_state (THUNAR_FILE (file_info), THUNAR_FILE_THUMB_STATE_UNKNOWN);

      /* tell the file monitor that this file changed */
      thunar_file_monitor_file_changed (THUNAR_FILE (file_info));
    }

    void
    thunar_file_set_thumb_state (ThunarFile          *file, 
                                 ThunarFileThumbState state)
    {
      _thunar_return_if_fail (THUNAR_IS_FILE (file));

      /* set the new thumbnail state */
      file->flags = (file->flags & ~THUNAR_FILE_THUMB_STATE_MASK) | (state);
      
      /* notify others of this change, so that all components can update
       * their file information */
      thunar_file_monitor_file_changed (file);
    }

Notice thunar_file_monitor_file_changed is called in *_set_thumb_state, but then *_set_thumb_state also calls it.

I'm assuming that having thunar_file_monitor_file_changed called twice is not the desired behavior, so I've attached a patch that removes the call from the thunar_file_info_changed function.