! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
_NET_WM_WINDOW_OPACITY_LOCKED breaks parole with most window managers
Status:
RESOLVED: FIXED

Comments

Description david 2009-12-16 17:06:11 CET
This commit 

http://git.xfce.org/apps/parole/commit/?id=fb4d0ef40e2bd01cabecab1238374fe907748d72

Breaks Parole with Openbox, and I assume every other window manager that is not xfwm4.

Maybe some kind of check could be performed to see if xfwm is running and the atom is renamed (which is an xfwm bug) as it is a non standard atom prefixed with _NET_WM.
Comment 1 Ali Abdallah editbugs 2009-12-16 23:50:15 CET
To be honest i was expecting problems with this commit, but testing it here with metacity doesn't seem to give any error, Parole runs fine if metacity if the window manager.

Could you please provide me more details about the error when you are trying to use Parole with Openbox? i will try to install Openbox myself, but it is appreciated if you give me more details...

Thanks,
Comment 2 david 2009-12-17 11:50:23 CET
The error on load is 

The program 'parole' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAtom (invalid Atom parameter)'.
  (Details: serial 208 error_code 5 request_code 18 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

I am not sure how metacity deals with atoms, and the title is probably a bit misleading (I tested it in openbox, blackbox and mutter) I believe xine had a similar issue some time ago, last time I checked _NET_WM_WINDOW_OPACITY_LOCKED was not part of the spec. By setting the atom to _NORMAL and rebuilding parole is able to run fine, but I don't have a less terrible 'fix'.

The wm spec explicitly states "An implementation MAY add new atoms to this list. Implementations without extensions MUST ignore any unknown atoms, effectively removing them from the list. These extension atoms MUST NOT start with the prefix _NET." Which might be an XFWM4 issue.
Comment 3 Ali Abdallah editbugs 2009-12-17 12:24:29 CET
Created attachment 2745 
Check if the _NET_WM_WINDOW_OPACITY_LOCKED_ATOM is created

I think we have just to check if the atom is valid, please try out the attached patch.
Comment 4 david 2009-12-17 12:41:45 CET
(In reply to comment #3)
> Created an attachment (id=2745) [details]
> Check if the _NET_WM_WINDOW_OPACITY_LOCKED_ATOM is created
> 
> I think we have just to check if the atom is valid, please try out the attached
> patch.

This works fine now thanks. However it still remains a non-standard atom, but I suppose that is more a xfwm4 issue :)
Comment 5 Ali Abdallah editbugs 2009-12-17 13:17:48 CET
> 
> This works fine now thanks. However it still remains a non-standard atom, but I
> suppose that is more a xfwm4 issue :)

This is another debate, this atom is really important and should be standardized, thanks for your report!

Bug #6088

Reported by:
david
Reported on: 2009-12-16
Last modified on: 2009-12-17

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Version:
0.1.99

Attachments

Additional information