! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch]Cache the workarea instead of computing it every time
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description Jérôme Guelfucci editbugs 2009-11-12 20:43:55 CET
Created attachment 2667 
Patch

I gave a try at caching the workarea, this is far from being perfect but it ~ works. There is one regression though, notifications are not replaced correctly after a monitor plug / unplug.

I also noticed that the rootwin signal is often received several times in a row, I don't really know how to only deal with the last one as we need to update things as fast as possible to be able to replace notifications (so a delay is not really a valid option, unless we replace notifications after a delay too).
Comment 1 Brian J. Tarricone (not reading bugmail) 2009-11-13 01:17:12 CET
Oh, I already have this half-finished locally.  But maybe your patch is better...
Comment 2 Brian J. Tarricone (not reading bugmail) 2010-04-12 08:59:46 CEST
Didn't build here; needed a gdk/gdkx.h include.

The regression is a little annoying, but not a showstopper.  It's only a transient problem that resolves itself after the notifications in question expire.

There's only one place where I could see that it'd be a problem: if there's a non-expiring notification up (like about battery being low or something).  But... let's hand-wave it away for now.

Pushed.

Bug #5975

Reported by:
Jérôme Guelfucci
Reported on: 2009-11-12
Last modified on: 2010-04-12

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Version:
unspecified

Attachments

Patch (7.05 KB, patch)
2009-11-12 20:43 CET , Jérôme Guelfucci
no flags

Additional information