! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Ensure Xfburn works correctly when hal support is compiled in, but it is not ...
Status:
RESOLVED: FIXED

Comments

Description David Mohr 2009-11-09 17:15:08 CET
What about people who use xubuntu 9.10? hal is no longer used in ubuntu 9.10,
so xfburn will exit with the following warning:

** (xfburn:6246): WARNING **: Could not get list of devices from HAL: The name
org.freedesktop.Hal was not provided by any .service files
Segmentation fault
Comment 1 Lionel Le Folgoc 2009-11-11 14:18:24 CET
Hal is still installed by default on Xubuntu.

I can see two reasons for this "bug":
1/ hal crashed, and isn't started (I've often had this bug with karmic)
2/ xfburn has been installed on a GNOME system (which uses devkit), and the 'hal' package isn't installed (xfburn depends on libthunarvfs that depends on libhal*, but not on the 'hal' package providing the dbus service).

Could you give more info about this crash (is it 1 or 2?)? Thanks.
Comment 2 Lionel Le Folgoc 2009-11-11 14:36:31 CET
(or the real bug is that xfburn crashes when hal isn't running ;)
Comment 3 Yves-Alexis Perez editbugs 2009-11-11 14:42:16 CET
Hmmh, yeah, if xfburn is built with hal support but hal isn't running, it'll die badly:

corsac@hidalgo: sudo invoke-rc.d hal stop
Stopping Hardware abstraction layer: hald.
corsac@hidalgo: xfburn
** Message: Using Thunar-VFS 1.0.1
** Message: Using HAL

** (xfburn:15168): WARNING **: Could not get list of devices from HAL: The name org.freedesktop.Hal was not provided by any .service files
[1]    15168 segmentation fault  xfburn
corsac@hidalgo: sudo invoke-rc.d hal start
Starting Hardware abstraction layer: hald.
corsac@hidalgo: xfburn
** Message: Using Thunar-VFS 1.0.1
** Message: Using HAL
** Message: HAL said there are 0 burners, checking libburn if it can detect any
** Message: Using gstreamer transcoder.

(not sure why hal says “0 burners” especially since libburn correctly detects it). It'd be nice if xfburn could survive correctly to hal absence (even if built with it).

I'll adjust the dependency in debian but it'd still be nice to have that correct (before transition to devicekit-disk or whatever).

Cheers,
--
Yves-Alexis
Comment 4 David Mohr 2009-11-11 16:48:43 CET
Thanks for the feedback Lionel, good to know that hal seems unstable.

So on a gnome system with devkit hal is not running any more?


Thanks for debugging this a bit Yves-Alexis. It's of course a bug that xfburn crashes, I'll look into it. So I guess for now hal is required _if_ support is built in.
Comment 5 David Mohr 2009-11-12 03:44:31 CET
(In reply to comment #3)
> Hmmh, yeah, if xfburn is built with hal support but hal isn't running, it'll
> die badly:
> 
> corsac@hidalgo: sudo invoke-rc.d hal stop
> Stopping Hardware abstraction layer: hald.
> corsac@hidalgo: xfburn
> ** Message: Using Thunar-VFS 1.0.1
> ** Message: Using HAL
> 
> ** (xfburn:15168): WARNING **: Could not get list of devices from HAL: The name
> org.freedesktop.Hal was not provided by any .service files
> [1]    15168 segmentation fault  xfburn

This was supposed to work already, but I made a mistake. It has been fixed in master:
commit f4e2afea91a05b3ae05960a3c799952810a105e8
Author: David Mohr <squisher@xfce.org>
Date:   Wed Nov 11 20:26:35 2009 -0700

    uint screwed up the -1 return

> corsac@hidalgo: sudo invoke-rc.d hal start
> Starting Hardware abstraction layer: hald.
> corsac@hidalgo: xfburn
> ** Message: Using Thunar-VFS 1.0.1
> ** Message: Using HAL
> ** Message: HAL said there are 0 burners, checking libburn if it can detect any
> ** Message: Using gstreamer transcoder.
> 
> (not sure why hal says “0 burners” especially since libburn correctly detects
> it). It'd be nice if xfburn could survive correctly to hal absence (even if
> built with it).

I was testing this, and just had the same issue. I think hal behaves a bit funny when restarted from a desktop session (i.e. lshal doesn't list my burners any more). I think it'll work fine after a logout / reboot. If not, please let me know.

> I'll adjust the dependency in debian but it'd still be nice to have that
> correct (before transition to devicekit-disk or whatever).

Hmm, yeah, maybe that would be for the better. I'll release a bugfix version sometime soonish, but first I have to figure out all issues with the new ubuntu / fedora.
Comment 6 David Mohr 2010-02-01 19:59:44 CET
Since I was wrong about ubuntu's 9.10 hal support, I'm updating the title of the bug to reflect what work still needs to get done.

The commit mentioned above might be all that was needed, but I'll verify before I release.
Comment 7 David Mohr 2010-02-02 02:18:43 CET
I just tried running Xfburn without hal, and it seems to work fine. Speak up quickly if you believe there are further issues, so they can get fixed before the next release.

Thanks again everyone for your testing.

Bug #5965

Reported by:
David Mohr
Reported on: 2009-11-09
Last modified on: 2010-02-02

People

Assignee:
Xfburn Bug Triage
CC List:
2 users

Version

Attachments

Additional information