! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
bad xml quoting when storing values
Status:
CLOSED: FIXED
Product:
Xfce-mcs
Component:
General

Comments

Description Lalo Martins 2004-12-13 07:57:14 CET
(not sure if bug is in mcs-manager or desktop, guessing)

If I store a value that's not valid XML - for example, a filename with an
ampersand - it's not xml-quoted. When I next login, that setting is lost.

Reproducible: Always
Steps to Reproduce:
1. create an image with an ampersand in the filename. For example
"~/images/eris&chao.jpg".
2. set it as your desktop background.
3. log out.
4. log in again.

Actual Results:  
a. background was reset to the defaults.

b. if between steps 3 and 4 I look at .config/xfce4/mcs_settings/desktop.xml I see
    <option name="imagepath_0_0" type="string"
value="/home/lalo/images/eris&chao.jpg"/> (bad xml)

Expected Results:  
a. background remains what I set.

b. if between steps 3 and 4 I look at .config/xfce4/mcs_settings/desktop.xml I see
    <option name="imagepath_0_0" type="string"
value="/home/lalo/images/eris&amp;chao.jpg"/> (valid xml)

If I actually edit desktop.xml by hand and put the &amp; there, it works, well,
at least until I open the desktop settings applet again :-)

% dpkg -s xfce4-mcs-manager | grep Version
Version: 4.1.99.2+cvs.20041203-1
% dpkg -s xfdesktop4 | grep Version
Version: 4.3.5+cvs.20041203-3
Comment 1 Benedikt Meurer editbugs 2004-12-13 10:20:15 CET
The problem was in libxfce4mcs and its fixed now in CVS. Interestingly, you were
the first one to notice that bug in about 4 years. :-)
Comment 2 Lalo Martins 2004-12-13 12:50:23 CET
maybe because filenames with ampersands are weird and evil ;-)

good job btw, fixing it in (seemingly) 20min. Thanks!

Bug #590

Reported by:
Lalo Martins
Reported on: 2004-12-13
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information