! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
failed to build with xextproto>7.0.5 (missing dpmsstr.h)
Status:
RESOLVED: WONTFIX
Product:
Xfce4-power-manager
Component:
General

Comments

Description Unnamed_Hero 2009-10-22 09:45:43 CEST
as it says in http://lists.freedesktop.org/archives/xorg/2009-July/046521.html
dpmsstr.h is splited up into dpmsconst.h and dpmsproto.

so, solution is to change X11/extensions/dpmsstr.h to X11/extensions/dpmsconst.h in xfpm-dmps.c while compiling against new xextproto lib
Comment 1 Ali Abdallah editbugs 2009-10-22 11:40:42 CEST
(In reply to comment #0)
> as it says in http://lists.freedesktop.org/archives/xorg/2009-July/046521.html
> dpmsstr.h is splited up into dpmsconst.h and dpmsproto.
> 
> so, solution is to change X11/extensions/dpmsstr.h to
> X11/extensions/dpmsconst.h in xfpm-dmps.c while compiling against new xextproto
> lib

Many thanks for the report, i'm following up this thread now, i need a version macro to check xextproto version to keep backward compatibility.

will keep you informed.
Comment 2 Christoph Mende 2009-10-28 22:59:11 CET
AFAIK, you're supposed to use dpms.h only (which is shipped with libXext as of 1.1, previously it was shipped by xextproto)

This simple patch makes it compile and work fine over here:
diff --git a/src/xfpm-dpms.h b/src/xfpm-dpms.h
index 9a5b1d4..067622f 100644
--- a/src/xfpm-dpms.h
+++ b/src/xfpm-dpms.h
@@ -34,7 +34,6 @@
 #include <gdk/gdkx.h>
 #include <X11/Xproto.h>
 #include <X11/extensions/dpms.h>
-#include <X11/extensions/dpmsstr.h>

 G_BEGIN_DECLS
Comment 3 Ali Abdallah editbugs 2009-10-30 07:30:30 CET
(In reply to comment #2)
> AFAIK, you're supposed to use dpms.h only (which is shipped with libXext as of
> 1.1, previously it was shipped by xextproto)
> 
> This simple patch makes it compile and work fine over here:
> diff --git a/src/xfpm-dpms.h b/src/xfpm-dpms.h
> index 9a5b1d4..067622f 100644
> --- a/src/xfpm-dpms.h
> +++ b/src/xfpm-dpms.h
> @@ -34,7 +34,6 @@
>  #include <gdk/gdkx.h>
>  #include <X11/Xproto.h>
>  #include <X11/extensions/dpms.h>
> -#include <X11/extensions/dpmsstr.h>
> 
>  G_BEGIN_DECLS


This will make xfpm compiles on the newer xextproto?
Comment 4 Christoph Mende 2009-10-30 13:23:58 CET
Exactly, compiles and works fine (DPMS also tested) here, haven't checked on older libXext/xextproto though
Comment 5 Ali Abdallah editbugs 2011-09-09 10:57:19 CEST
version 0.8.x no longer supported.

Bug #5897

Reported by:
Unnamed_Hero
Reported on: 2009-10-22
Last modified on: 2011-09-09

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Attachments

Additional information