! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
panel with sawfish-1.2-gtk1: panel hidden by maximized windows
Status:
RESOLVED: WONTFIX
Severity:
trivial
Product:
Xfce4-panel

Comments

Description osth 2004-12-11 11:06:23 CET
Having started (and enjoyed...) to use xfce4.2rc1 (panel+desktop) with SPBLinux
(http://spblinux.sf.net) I noticed, that the panel does get covered by other
windows.
It is caused by sawfish-1.2-gtk1 which does not recognize WM_STRUT_PARTIAL

The patch included below works in my setup and you might consider to integrate
it in xcfe.
(Updating sawfish is not an option for SPBLinux because it is an extendable,
lightweight system which runs in RAM and uses gtk2 and xfce only as an optional
addon)

Christian Ostheimer

--- xfce4-panel-4.1.99.1/panel/panel.c.orig	2004-11-10 19:49:13.000000000 +0000
+++ xfce4-panel-4.1.99.1/panel/panel.c	2004-12-11 10:11:46.000000000 +0000
@@ -234,11 +234,18 @@
 	 data[6], data[7], data[8], data[9], data[10], data[11]);
 
     gdk_error_trap_push ();
-
+    /* if wm supports STRUT_PARTIAL it will ignore STRUT (A.A.)*/
     gdk_property_change (p->toplevel->window,
 			 gdk_atom_intern ("_NET_WM_STRUT_PARTIAL", FALSE),
 			 gdk_atom_intern ("CARDINAL", FALSE), 32,
 			 GDK_PROP_MODE_REPLACE, (guchar *) & data, 12);
+// support wm without STRUT_PARTIAL idea taken from fbpanel (coded by Anatoly
Asviyan)
+    /* old spec, for wms that do not support STRUT_PARTIAL (A.A.)*/
+    gdk_property_change (p->toplevel->window,
+			 gdk_atom_intern ("_NET_WM_STRUT", FALSE),
+			 gdk_atom_intern ("CARDINAL", FALSE), 32,
+			 GDK_PROP_MODE_REPLACE, (guchar *) & data, 4);
+
 
     gdk_error_trap_pop ();
 }


Reproducible: Always
Steps to Reproduce:
1. compile xfce4-panel for SPBLinux
2. run the panel and maximize any window
3. 

Actual Results:  
panel gets partially hidden by maximized window


the problem is related to xfce4-panel, NOT to any component of it; but bugzilla
forces me to assign it to a component of the panel.
Comment 1 Jasper Huijsmans editbugs 2004-12-11 15:45:29 CET
Hi. What happens when you have the panel at the top of the screen? I'm afraid in
that case the wm will refuse to move any window in the space next to the panel.
Comment 2 osth 2004-12-11 16:31:06 CET
(In reply to comment #1)
> Hi. What happens when you have the panel at the top of the screen? I'm afraid 
in
> that case the wm will refuse to move any window in the space next to the 
panel.
Does not happen: the panel position is locked and panel settings only allow 
bottom or right side. - I would need an information how to put the panel to the 
top.
Comment 3 Jasper Huijsmans editbugs 2004-12-11 16:37:02 CET
(In reply to comment #2)
> (In reply to comment #1)
> > Hi. What happens when you have the panel at the top of the screen? I'm afraid 
> in
> > that case the wm will refuse to move any window in the space next to the 
> panel.
> Does not happen: the panel position is locked and panel settings only allow 
> bottom or right side. - I would need an information how to put the panel to the 
> top.
> 

Oh, you can simply drag the panel handle over half the screen and it will flip
to the other side.
Comment 4 osth 2004-12-11 16:49:52 CET
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Hi. What happens when you have the panel at the top of the screen? I'm 
afraid 
> > in
> > > that case the wm will refuse to move any window in the space next to the 
> > panel.
> > Does not happen: the panel position is locked and panel settings only allow 
> > bottom or right side. - I would need an information how to put the panel to 
the 
> > top.
> > 
> Oh, you can simply drag the panel handle over half the screen and it will flip
> to the other side.
Beginning to learn the secrets of xfce... But in my case clicking on the handle 
and dragging changes the cursor but nothing else happens. However I am not sure 
if it is my setup (XDirectFB, old sawfish version, minimal set of X libraries) 
or if it is xfce-panel. - Any other way to bring the panel to the top?

Comment 5 osth 2004-12-11 17:48:51 CET
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > Hi. What happens when you have the panel at the top of the screen? I'm 
> afraid 
> > > in
> > > > that case the wm will refuse to move any window in the space next to 
the 
> > > panel.
> > > Does not happen: the panel position is locked and panel settings only 
allow 
> > > bottom or right side. - I would need an information how to put the panel 
to 
> the 
> > > top.
> > > 
> > Oh, you can simply drag the panel handle over half the screen and it will 
flip
> > to the other side.
> Beginning to learn the secrets of xfce... But in my case clicking on the 
handle 
> and dragging changes the cursor but nothing else happens. However I am not 
sure 
> if it is my setup (XDirectFB, old sawfish version, minimal set of X 
libraries) 
> or if it is xfce-panel. - Any other way to bring the panel to the top?
Ok, that was a bug of sawfish-1.2 which is now patched. So, with the panel on 
the top of the screen:
- maximizing works as it should
- opening new windows: correct size, but wrong position: on top, hiding panel
(same vertical panel: right position ok, left position not)
Comment 6 Jasper Huijsmans editbugs 2004-12-11 18:07:51 CET
Ok, I'm not sure what to do. 

To me setting full struts doesn't sound like the proper solution, since that
basically means claiming the entire side of the screen and I'd expect some
window managers to prevent moving windows in the empty space next to the window.

OTOH, there are probably not that many people using a window manager different
from xfwm4, supporting full struts but not partial ones.
Comment 7 osth 2004-12-11 19:08:45 CET
(In reply to comment #6)
> Ok, I'm not sure what to do. 
> To me setting full struts doesn't sound like the proper solution, since that
> basically means claiming the entire side of the screen and I'd expect some
> window managers to prevent moving windows in the empty space next to the 
window.
> OTOH, there are probably not that many people using a window manager different
> from xfwm4, supporting full struts but not partial ones.

Well, either drop it or include the patch as lines which are commented out;
then a small note about sawfish-1.2 in the changelog should be enough.

Thanks for your support, Christian
Comment 8 Jasper Huijsmans editbugs 2004-12-11 19:23:49 CET
Ok, in I prefer not to put it in. Thanks.

Bug #587

Reported by:
osth
Reported on: 2004-12-11
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Attachments

Additional information