5835 – Terminal-0.4.0 parallel unsafe Makefile causes race on case in-sensitive filesystems

Terminal-0.4.0 parallel unsafe Makefile causes race on case in-sensitive file...

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xfce4-terminal

Component:

General

Comments

Description Jeremy Olexa 2009-10-06 15:58:22 CEST

Hello, our interix developer found this race condition in the Makefile. Please see patch here: http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/x11-terms/terminal/files/terminal-0.4.0-interix-fs-case.patch?rev=50847 Applies to newer versions as well.

Thanks.

Comment 1 Nick Schermer editbugs

2009-10-06 16:21:14 CEST

Duno if this is the right fix, but it seems to give no trouble here. Jannis, what do you think? Same thing is in thunar too.

Comment 2 Nick Schermer editbugs

2009-10-08 10:06:46 CEST

Created attachment 2589 
Use install-exec-hook.

Could you try the attached patch? If I'm right hooks are always executed after the data installation and install-exec is more suitable for symlinks to binaries.

Comment 3 Jeremy Olexa 2009-10-08 13:30:24 CEST

Looks good Nick, thanks.

Bug #5835

Reported by:
Jeremy Olexa

Reported on: 2009-10-06
Last modified on: 2009-10-08

People

Assignee:
Nick Schermer

CC List:
1 user

Version

Version:
unspecified

Target Milestone:
0.2

Attachments

Use install-exec-hook. (391 bytes, patch)
2009-10-08 10:06 CEST , Nick Schermer

no flags

Additional information